Apply clang-tidy11 to random

diff --git a/src/gromacs/random/exponentialdistribution.h b/src/gromacs/random/exponentialdistribution.h
index f8cd205d58f3410deba5fc6b2cad5dfbc0cb3c4a..a038f1f09e9fcdfe7436389950019cc64828efdc 100644 (file)
--- a/src/gromacs/random/exponentialdistribution.h
+++ b/src/gromacs/random/exponentialdistribution.h
@@ -135,7 +135,6 @@ public:
         bool operator!=(const param_type& x) const { return !operator==(x); }
     };
 
-public:
     /*! \brief Construct new distribution with given floating-point parameter.
      *
      * \param lambda   lambda/decay parameter

diff --git a/src/gromacs/random/gammadistribution.h b/src/gromacs/random/gammadistribution.h
index 9c2759d0bcc0d6154e483e945319d6163d7f8862..0b23b04c7949505e1bff14c8df7d30a2c68a30b7 100644 (file)
--- a/src/gromacs/random/gammadistribution.h
+++ b/src/gromacs/random/gammadistribution.h
@@ -167,7 +167,6 @@ public:
         bool operator!=(const param_type& x) const { return !operator==(x); }
     };
 
-public:
     /*! \brief Construct new distribution with given floating-point parameters.
      *
      * \param alpha  First parameter of gamma distribution

diff --git a/src/gromacs/random/normaldistribution.h b/src/gromacs/random/normaldistribution.h
index 13bcfb1636af3f780e47fd7672945255c310a19d..4380758705f52d7f9d2fd7e0bdb890efc11d9a02 100644 (file)
--- a/src/gromacs/random/normaldistribution.h
+++ b/src/gromacs/random/normaldistribution.h
@@ -152,7 +152,6 @@ public:
         bool operator!=(const param_type& x) const { return !operator==(x); }
     };
 
-public:
     /*! \brief Construct new distribution with given floating-point parameters.
      *
      * \param mean     Mean of normal distribution

diff --git a/src/gromacs/random/tabulatednormaldistribution.h b/src/gromacs/random/tabulatednormaldistribution.h
index f8217226fafd516ce4aa924d1d139f07247163fc..1664c286ca5eb161f736de03a692cff0d444b5e4 100644 (file)
--- a/src/gromacs/random/tabulatednormaldistribution.h
+++ b/src/gromacs/random/tabulatednormaldistribution.h
@@ -213,7 +213,6 @@ public:
         return table;
     }
 
-public:
     /*! \brief Construct new normal distribution with specified mean & stdddev.
      *
      *  \param mean    Mean value of tabulated normal distribution

diff --git a/src/gromacs/random/tests/.clang-tidy b/src/gromacs/random/tests/.clang-tidy
new file mode 100644 (file)
index 0000000..0adf51e
--- /dev/null
+++ b/src/gromacs/random/tests/.clang-tidy
@@ -0,0 +1,91 @@
+# List of rationales for check suppressions (where known).
+# This have to precede the list because inline comments are not
+# supported by clang-tidy.
+#
+#         -cppcoreguidelines-non-private-member-variables-in-classes,
+#         -misc-non-private-member-variables-in-classes,
+# We intend a gradual transition to conform to this guideline, but it
+# is not practical to implement yet.
+#
+#         -readability-isolate-declaration,
+# Declarations like "int a, b;" are readable. Some forms are not, and
+# those might reasonably be suggested against during code review.
+#
+#         -cppcoreguidelines-avoid-c-arrays,
+# C arrays are still necessary in many places with legacy code
+#
+#         -cppcoreguidelines-avoid-magic-numbers,
+#         -readability-magic-numbers,
+# We have many legitimate use cases for magic numbers
+#
+#         -cppcoreguidelines-macro-usage,
+# We do use too many macros, and we should fix many of them, but there
+# is no reasonable way to suppress the check e.g. in src/config.h and
+# configuring the build is a major legitimate use of macros.
+#
+#         -cppcoreguidelines-narrowing-conversions,
+#         -bugprone-narrowing-conversions
+# We have many cases where int is converted to float and we don't care
+# enough about such potential loss of precision to use explicit casts
+# in large numbers of places.
+#
+#         -google-readability-avoid-underscore-in-googletest-name
+# We need to use underscores for readability for our legacy types
+# and command-line parameter names
+#
+#         -misc-no-recursion
+# We have way too many functions and methods relying on recursion
+#
+#         -cppcoreguidelines-avoid-non-const-global-variables
+# There are quite a lot of static variables in the test code that
+# can not be replaced.
+#
+#         -modernize-avoid-bind
+# Some code needs to use std::bind and can't be modernized quickly.
+Checks:  clang-diagnostic-*,-clang-analyzer-*,-clang-analyzer-security.insecureAPI.strcpy,
+         bugprone-*,misc-*,readability-*,performance-*,mpi-*,
+         -readability-inconsistent-declaration-parameter-name,
+         -readability-function-size,-readability-else-after-return,
+         modernize-use-nullptr,modernize-use-emplace,
+         modernize-make-unique,modernize-make-shared,
+         modernize-avoid-bind,
+         modernize-use-override,
+         modernize-redundant-void-arg,modernize-use-bool-literals,
+         cppcoreguidelines-*,-cppcoreguidelines-pro-*,-cppcoreguidelines-owning-memory,
+         -cppcoreguidelines-no-malloc,-cppcoreguidelines-special-member-functions,
+         -cppcoreguidelines-avoid-goto,
+         google-*,-google-build-using-namespace,-google-explicit-constructor,
+         -google-readability-function-size,-google-readability-todo,-google-runtime-int,
+         -cppcoreguidelines-non-private-member-variables-in-classes,
+         -misc-non-private-member-variables-in-classes,
+         -readability-isolate-declaration,
+         -cppcoreguidelines-avoid-c-arrays,
+         -cppcoreguidelines-avoid-magic-numbers,
+         -readability-magic-numbers,
+         -cppcoreguidelines-macro-usage,
+         -cppcoreguidelines-narrowing-conversions,
+         -bugprone-narrowing-conversions,
+         -google-readability-avoid-underscore-in-googletest-name,
+         -cppcoreguidelines-init-variables,
+         -misc-no-recursion,
+         -cppcoreguidelines-avoid-non-const-global-variables,
+         -modernize-avoid-bind
+HeaderFilterRegex: .*
+CheckOptions:
+  - key:           cppcoreguidelines-special-member-functions.AllowSoleDefaultDtor
+    value:         1
+  - key:           modernize-make-unique.IncludeStyle
+    value:         google
+  - key:           modernize-make-shared.IncludeStyle
+    value:         google
+  - key:           readability-implicit-bool-conversion.AllowIntegerConditions
+    value:         1
+  - key:           readability-implicit-bool-conversion.AllowPointerConditions
+    value:         1
+  - key:           bugprone-dangling-handle.HandleClasses
+    value:         std::basic_string_view; nonstd::sv_lite::basic_string_view
+# Permit passing shard pointers by value for sink parameters
+  - key:           performance-unnecessary-copy-initialization.AllowedTypes
+    value:         shared_ptr
+  - key:           performance-unnecessary-value-param.AllowedTypes
+    value:         shared_ptr

diff --git a/src/gromacs/random/uniformintdistribution.h b/src/gromacs/random/uniformintdistribution.h
index 468902646c20ba4a044086ddb0e87b9b2422a12d..2e2b4835ea715ffdd8071c3cae28fdbf202ace52 100644 (file)
--- a/src/gromacs/random/uniformintdistribution.h
+++ b/src/gromacs/random/uniformintdistribution.h
@@ -122,7 +122,6 @@ public:
         bool operator!=(const param_type& x) const { return !operator==(x); }
     };
 
-public:
     /*! \brief Construct new distribution with given integer parameters.
      *
      * \param a   Lower end of range (inclusive)

diff --git a/src/gromacs/random/uniformrealdistribution.h b/src/gromacs/random/uniformrealdistribution.h
index 7c7c38720381f86f7df03136a1b2cc9f1537243d..f54fb43d222868e964d006afcfe974f49c26f05f 100644 (file)
--- a/src/gromacs/random/uniformrealdistribution.h
+++ b/src/gromacs/random/uniformrealdistribution.h
@@ -211,7 +211,6 @@ public:
         bool operator!=(const param_type& x) const { return !operator==(x); }
     };
 
-public:
     /*! \brief Construct new distribution with given floating-point parameters.
      *
      * \param a   Lower end of range (inclusive)