Fix mis-use of fabs in LAPACK

clang-3.5 warns that fabs is not the right approach.

Change-Id: Ib7125fcad2f4fda99abf7b67f296f24d84cb34be

diff --git a/src/gromacs/linearalgebra/gmx_lapack/dlagts.c b/src/gromacs/linearalgebra/gmx_lapack/dlagts.c
index 51cbb2b11cfb29b8c2dc08035da522986bd4f395..09dad0d76a421743d67b6e94e0c49d0b37cbcdb9 100644 (file)
--- a/src/gromacs/linearalgebra/gmx_lapack/dlagts.c
+++ b/src/gromacs/linearalgebra/gmx_lapack/dlagts.c
@@ -1,3 +1,4 @@
+#include <stdlib.h>
 #include <math.h>
 #include "gromacs/utility/real.h"
 
@@ -31,7 +32,7 @@ F77_FUNC(dlagts,DLAGTS)(int *job,
     --a;
 
     *info = 0;
-    if (fabs(*job) > 2 || *job == 0) {
+    if (abs(*job) > 2 || *job == 0) {
        *info = -1;
     } else if (*n < 0) {
        *info = -2;
@@ -77,7 +78,7 @@ F77_FUNC(dlagts,DLAGTS)(int *job,
        }
     }
 
-    if (fabs(fabs(*job)-1.0)<GMX_DOUBLE_MIN) {
+    if (1 == abs(*job)) {
        i__1 = *n;
        for (k = 2; k <= i__1; ++k) {
            if (in[k - 1] == 0) {

diff --git a/src/gromacs/linearalgebra/gmx_lapack/slagts.c b/src/gromacs/linearalgebra/gmx_lapack/slagts.c
index cd16a34a21ae67f2ee0189b96061a21a6a9c173b..2b8beb751c78bfd28b47eb61e940ff7575965541 100644 (file)
--- a/src/gromacs/linearalgebra/gmx_lapack/slagts.c
+++ b/src/gromacs/linearalgebra/gmx_lapack/slagts.c
@@ -1,3 +1,4 @@
+#include <stdlib.h>
 #include <math.h>
 #include "gromacs/utility/real.h"
 
@@ -31,7 +32,7 @@ F77_FUNC(slagts,SLAGTS)(int *job,
     --a;
 
     *info = 0;
-    if (fabs(*job) > 2 || *job == 0) {
+    if (abs(*job) > 2 || *job == 0) {
        *info = -1;
     } else if (*n < 0) {
        *info = -2;
@@ -77,7 +78,7 @@ F77_FUNC(slagts,SLAGTS)(int *job,
        }
     }
 
-    if (fabs(fabs(*job)-1.0)<GMX_FLOAT_MIN) {
+    if (1 == abs(*job)) {
        i__1 = *n;
        for (k = 2; k <= i__1; ++k) {
            if (in[k - 1] == 0) {