Fix memory corruption with strings in grompp

Using a string of more than 31 characters as a default value for
a string entry in the mdp file would lead to memory corruption.

diff --git a/src/gromacs/fileio/readinp.cpp b/src/gromacs/fileio/readinp.cpp
index 907e49050a7c5fd639115e831a5e4c1bbe8c997f..10797d31e79af884ba1e09ded56f919f888c25fb 100644 (file)
--- a/src/gromacs/fileio/readinp.cpp
+++ b/src/gromacs/fileio/readinp.cpp
@@ -452,7 +452,6 @@ double get_ereal(std::vector<t_inpfile>* inp, const std::string& name, double de
 const char* get_estr(std::vector<t_inpfile>* inp, const char* name, const char* def)
 {
     std::vector<t_inpfile>& inpRef = *inp;
-    char                    buf[32];
 
     int ii = get_einp(inp, name);
 
@@ -460,8 +459,7 @@ const char* get_estr(std::vector<t_inpfile>* inp, const char* name, const char*
     {
         if (def)
         {
-            sprintf(buf, "%s", def);
-            inpRef.back().value_.assign(buf);
+            inpRef.back().value_.assign(def);
         }
         else
         {