Fix incorrect header and linter scripts
authorPaul Bauer <paul.bauer.q@gmail.com>
Thu, 30 Apr 2020 12:03:15 +0000 (14:03 +0200)
committerPaul Bauer <paul.bauer.q@gmail.com>
Thu, 30 Apr 2020 13:21:43 +0000 (13:21 +0000)
Wrong grep flag meant that messages have not been printed.

Change-Id: I74b2088a12753d584929f9aa75ed915d400d8091

admin/containers/utility.py
admin/gitlab-ci/lint.gitlab-ci.yml

index 473881e4af4bf617b438939f6247eb6e91a25448..e413a19be0c7f1fb661ddf9cd54f33dfd8b62e7b 100644 (file)
@@ -1,3 +1,4 @@
+#
 # This file is part of the GROMACS molecular simulation package.
 #
 # Copyright (c) 2020, by the GROMACS development team, led by
index e259e7d7dba18bcfaca9a7b1025163dc94338cb2..840b26969ff65f77fbfc2d31ff9aa102441e632f 100644 (file)
@@ -57,7 +57,7 @@ clang-tidy:test:
   script:
     - REV=$(git fetch -q https://gitlab.com/gromacs/gromacs.git release-2020 && git show -s --pretty=format:"%h" `git merge-base --fork-point FETCH_HEAD HEAD`)
     - RUN_CLANG_TIDY=run-clang-tidy-$COMPILER_MAJOR_VERSION bash admin/clang-tidy.sh check --parallel=$KUBERNETES_CPU_LIMIT --warnings=clang-tidy.log --rev=$REV -B=$BUILD_DIR
-    - grep -iq "found code issues" clang-tidy.log | tee code-lint.txt || true
+    - grep -i "found code issues" clang-tidy.log | tee code-lint.txt || true
     - if [ -s code-lint.txt ] ; then echo "clang-tidy.sh found issues"; exit 1; fi
   artifacts:
     when: on_failure
@@ -82,7 +82,7 @@ clang-format:
   script:
     - REV=$(git fetch -q https://gitlab.com/gromacs/gromacs.git release-2020 && git show -s --pretty=format:"%h" `git merge-base FETCH_HEAD HEAD`)
     - CLANG_FORMAT=clang-format-$COMPILER_MAJOR_VERSION admin/clang-format.sh check --rev=$REV --warnings=clang-format.log
-    - grep -iq "needs formatting" clang-format.log | tee formatting.txt || true
+    - grep -i "needs formatting" clang-format.log | tee formatting.txt || true
     - if [ -s formatting.txt ] ; then echo "clang-format.sh found issues"; exit 1; fi
   artifacts:
     when: on_failure
@@ -105,8 +105,8 @@ copyright-check:
   script:
     - REV=$(git fetch -q https://gitlab.com/gromacs/gromacs.git release-2020 && git show -s --pretty=format:"%h" `git merge-base FETCH_HEAD HEAD`)
     - admin/copyright.sh check --rev=$REV --warnings=copyright.log
-    - grep -iq "copyright year" copyright.log | tee years.log || true
-    - grep -iq "copyright header" copyright.log | tee headers.log || true
+    - grep -i "copyright year" copyright.log | tee years.log || true
+    - grep -i "copyright header" copyright.log | tee headers.log || true
     - if [[ -s years.log || -s headers.log ]] ; then
       echo "Copyright information needs updating" ;
       exit 1 ;