Remove useless comments
authorRoland Schulz <roland.schulz@intel.com>
Wed, 12 Sep 2018 18:40:50 +0000 (11:40 -0700)
committerMagnus Lundborg <magnus.lundborg@scilifelab.se>
Thu, 13 Sep 2018 08:16:26 +0000 (10:16 +0200)
Change-Id: I6df536841e9307491db8d3e9a529803724375d89

28 files changed:
src/gromacs/awh/awh.h
src/gromacs/awh/tests/bias.cpp
src/gromacs/awh/tests/biasstate.cpp
src/gromacs/domdec/domdec_internal.h
src/gromacs/ewald/tests/pmebsplinetest.cpp
src/gromacs/ewald/tests/pmegathertest.cpp
src/gromacs/ewald/tests/pmesolvetest.cpp
src/gromacs/ewald/tests/pmesplinespreadtest.cpp
src/gromacs/gpu_utils/tests/gputest.h
src/gromacs/mdlib/constr.h
src/gromacs/mdlib/mdatoms.h
src/gromacs/mdlib/mdebin_bar.h
src/gromacs/mdlib/mdrun.h
src/gromacs/mdlib/nbnxn_internal.h
src/gromacs/mdlib/tests/settle.cpp
src/gromacs/mdlib/tests/simulationsignal.cpp
src/gromacs/mdlib/vsite.h
src/gromacs/mdtypes/energyhistory.h
src/gromacs/mdtypes/observableshistory.h
src/gromacs/mdtypes/state.h
src/gromacs/options/abstractsection.h
src/gromacs/taskassignment/resourcedivision.cpp
src/gromacs/topology/topology.h
src/gromacs/utility/iserializer.h
src/gromacs/utility/tests/mutex.cpp
src/programs/mdrun/tests/energyreader.h
src/programs/mdrun/tests/multisimtest.h
src/programs/mdrun/tests/trajectoryreader.h

index dd8618af58a981550ef13b915f5c51377bb9e8e7..c9ce020918e82f06bb166c9b06def28077c68a2f 100644 (file)
@@ -131,7 +131,6 @@ class Awh
             const std::string    &biasInitFilename,
             pull_t               *pull_work);
 
-        /*! \brief Destructor. */
         ~Awh();
 
         /*! \brief Peform an AWH update, to be called every MD step.
index 1c9928adfd32ac6116007efa218664ad7e5f876c..033ad06d2276683d812689d8d80afa0db72ee26a 100644 (file)
@@ -165,7 +165,6 @@ class BiasTest : public ::testing::TestWithParam<BiasTestParameters>
         //! The awh Bias
         std::unique_ptr<Bias> bias_;
 
-        //! Constructor
         BiasTest() :
             coordinates_(std::begin(g_coords), std::end(g_coords))
         {
index c7d2080306e92678dcebfb0f2e6e0c6e2f846fdc..57f518ccd202bd351b7fe2474bbe84dab6270346 100644 (file)
@@ -130,7 +130,6 @@ class BiasStateTest : public ::testing::TestWithParam<const char *>
     public:
         std::unique_ptr<BiasState> biasState_;  //!< The bias state
 
-        //! Constructor
         BiasStateTest()
         {
             AwhTestParameters       params        = getAwhTestParameters();
index 371aded2831e9a3d04efcd30efd184a7edc35c5b..5807f5379003402e7b88cf8de497aa6c26b2d420 100644 (file)
@@ -277,7 +277,6 @@ struct gmx_ddzone_t
 /*! \brief The number of reals in gmx_ddzone_t */
 constexpr int c_ddzoneNumReals = 7;
 
-/*! \brief Forward declaration */
 template<typename T> class DDBufferAccess;
 
 /*! \brief Temporary storage container that minimizes (re)allocation and clearing
@@ -342,7 +341,6 @@ class DDBufferAccess
             buffer = ddBuffer_.acquire(numElements);
         }
 
-        /*! \brief Destructor */
         ~DDBufferAccess()
         {
             ddBuffer_.release();
index b4c41798ffc71bbd223b25dac6c1ca838875f836..b57d2dd91bcd931ed3b7b9a1b33b35d6c01fec3f 100644 (file)
@@ -76,7 +76,6 @@ typedef std::tuple<IVec, int, ModuliType> BSplineModuliInputParameters;
 class PmeBSplineModuliTest : public ::testing::TestWithParam<BSplineModuliInputParameters>
 {
     public:
-        //! Default constructor
         PmeBSplineModuliTest() = default;
         //! The whole logic being tested is contained here
         void runTest()
index 2d86d12feb2fac3b9d0f22eff285f0f555194fe6..3cd1ede5b90778e68b0e245ac37bd0129443a8f1 100644 (file)
@@ -335,7 +335,6 @@ class PmeGatherTest : public ::testing::TestWithParam<GatherInputParameters>
         static InputDataByAtomCount s_inputAtomDataSets_;
 
     public:
-        //! Default constructor
         PmeGatherTest()  = default;
         //! Sets the input atom data references once
         static void SetUpTestCase()
index 148d27ba3b789e26395692ca0a6cd6b172e06922..3441f3ebeb3d2c57f193d806882520995ff7bf2d 100644 (file)
@@ -72,7 +72,6 @@ typedef std::tuple<Matrix3x3, IVec, SparseComplexGridValuesInput, double, double
 class PmeSolveTest : public ::testing::TestWithParam<SolveInputParameters>
 {
     public:
-        //! Default constructor
         PmeSolveTest() = default;
 
         //! The test
index 105f2ca37a280589820dd55f27719f26dbe0bffb..43c4b02852c4c006cc4cfc920fbeca94bce7d5de 100644 (file)
@@ -81,7 +81,6 @@ typedef std::tuple<Matrix3x3, int, IVec, CoordinatesVector, ChargesVector> Splin
 class PmeSplineAndSpreadTest : public ::testing::TestWithParam<SplineAndSpreadInputParameters>
 {
     public:
-        //! Default constructor
         PmeSplineAndSpreadTest() = default;
         //! The test
         void runTest()
index 3ee5e443f5589e21a5733e481ffe5cb7913c50fa..603ef7b0cec3cfbbb9c6002d5b3c5888cb337791 100644 (file)
@@ -58,9 +58,7 @@ class GpuTest : public ::testing::Test
         //! Information about GPUs that are present.
         gmx_gpu_info_t *gpuInfo_;
 
-        //! Constructor
         GpuTest();
-        //! Destructor
         ~GpuTest() override;
         //! Getter for convenience in testing
         bool haveValidGpus() const;
index c887bc27545faa4a6e68d5f7dcd6b5482b9c62d6..f1c5b1879b1194cca0187c1c7ca8288e7cd924c8 100644 (file)
@@ -114,7 +114,6 @@ class Constraints
          * constructor. */
         struct CreationHelper;
 
-        //! Destructor.
         ~Constraints();
 
         /*! \brief Returns the total number of flexible constraints in the system. */
index a77a043f4934069c1f157b6cc04ff74b91625523..76a5d072f82dc4a5e786aea75247507fb2c6f0fb 100644 (file)
@@ -72,9 +72,7 @@ class MDAtoms
     HostVector<real>       chargeA_;
     public:
         // TODO make this private
-        //! Constructor.
         MDAtoms();
-        //! Destructor.
         ~MDAtoms();
         //! Getter.
         t_mdatoms *mdatoms()
index 919ccd86b84786afb953ef07e496e3a60e51fb58..db42ac1bd2e79ff1da094e2b48d3c0f19411b597 100644 (file)
@@ -134,7 +134,6 @@ struct t_mde_delta_h_coll
 void mde_delta_h_coll_init(t_mde_delta_h_coll *dhc,
                            const t_inputrec   *ir);
 
-//! Destructor
 void done_mde_delta_h_coll(t_mde_delta_h_coll *dhc);
 
 /* add a bunch of samples to the delta_h collection
index ba9bb7860553b3a64d7a7e527aad81d4f18a3f87..7e88f8bcddd8cb1fd8c2f4c5250a3071ffb8b1b0 100644 (file)
@@ -78,7 +78,6 @@ struct ContinuationOptions
 //! \internal \brief Options for writing checkpoint files
 struct CheckpointOptions
 {
-    //! \brief Constructor
     CheckpointOptions() :
         keepAndNumberCheckpointFiles(FALSE),
         period(15)
@@ -110,7 +109,6 @@ struct TimingOptions
 //! \internal \brief Options for IMD
 struct ImdOptions
 {
-    //! Constructor
     ImdOptions() :
         port(8888),
         wait(FALSE),
index a9ac48efb85657e1e0de808228d743d04667ae50..21fe54271fab7e4db154a3121cc6feaa3830781b 100644 (file)
@@ -241,10 +241,8 @@ enum {
 /* Thread-local work struct, contains part of nbnxn_grid_t */
 struct nbnxn_search_work_t
 {
-    /* Constructor */
     nbnxn_search_work_t();
 
-    /* Destructor */
     ~nbnxn_search_work_t();
 
     gmx_cache_protect_t       cp0;          /* Buffer to avoid cache polution */
index ef9dc06c7fa7b3281b87ddea3abaa119bc8a45a4..6fd711ec9331373c4fb6eb9b379119adef9f912a 100644 (file)
@@ -143,7 +143,6 @@ class SettleTest : public ::testing::TestWithParam<SettleTestParameters>
         //! PBC option to test
         t_pbc             pbcXYZ_;
 
-        //! Constructor
         SettleTest() :
             updatedPositions_(std::begin(g_positions), std::end(g_positions)),
             velocities_(updatedPositions_.size(), 0)
index 408c511d425b056c0e13ceff0ca2bd65374c8063..20e718d92d3e5bee1521822de0ba13160be19d55 100644 (file)
@@ -65,7 +65,6 @@ TEST(NullSignalTest, NullSignallerWorks)
 class SignalTest : public ::testing::Test
 {
     public:
-        //! Constructor
         SignalTest() : signals_ {}
         {
             signals_[0].sig = 1;
index 98252a0f5a6b6f3cda24e579641824d0cc384cb7..b82751206a59532580233c9675c733033015e33f 100644 (file)
@@ -70,10 +70,8 @@ typedef std::array<std::vector<int>, c_ftypeVsiteEnd - c_ftypeVsiteStart> VsiteP
 /* Data for handling vsites, needed with OpenMP threading or with charge-groups and PBC */
 struct gmx_vsite_t
 {
-    /* Constructor */
     gmx_vsite_t();
 
-    /* Destructor */
     ~gmx_vsite_t();
 
     gmx_bool                  bHaveChargeGroups;         /* Do we have charge groups?               */
index dc14e1650584d2ab6bd8973b36e2f7b16d7b7854..61ffc4dc24eef8bd9a758e75f2ea606fa6bd6263 100644 (file)
@@ -69,7 +69,6 @@ class delta_h_history_t
         //! Whether the lambda value is set. Here for backward-compatibility.
         gmx_bool                        start_lambda_set;
 
-        //! Constructor
         delta_h_history_t() :
             start_time(0),
             start_lambda(0),
@@ -94,7 +93,6 @@ class energyhistory_t
         //! History for energy difference for foreign lambdas (useful for BAR)
         std::unique_ptr<delta_h_history_t> deltaHForeignLambdas;
 
-        //! Constructor
         energyhistory_t() : nsteps(0),
                             nsum(0),
 
index 2f1e9f9c283d287766be0c8b3cf49eeb6857ec42..61a67fe2ab26a2bb76eb505de5064af2242953fa 100644 (file)
@@ -1,7 +1,7 @@
 /*
  * This file is part of the GROMACS molecular simulation package.
  *
- * Copyright (c) 2016,2017, by the GROMACS development team, led by
+ * Copyright (c) 2016,2017,2018, by the GROMACS development team, led by
  * Mark Abraham, David van der Spoel, Berk Hess, and Erik Lindahl,
  * and including many others, as listed in the AUTHORS file in the
  * top-level source directory and at http://www.gromacs.org.
@@ -72,10 +72,8 @@ struct ObservablesHistory
     //! Ion/water position swapping history
     std::unique_ptr<swaphistory_t> swapHistory;
 
-    //! Default constructor
     ObservablesHistory();
 
-    //! Default destructor
     ~ObservablesHistory();
 };
 
index 8dc96970dd7d71cd12c8a1ad1254e1fa9f88377c..22a3c8c6b21011e9fd3038a79989a21f3ebfe928 100644 (file)
@@ -111,7 +111,6 @@ extern const char *est_names[estNR];
 class history_t
 {
     public:
-        //! Constructor
         history_t();
 
         real  disre_initf;  //!< The scaling factor for initializing the time av.
@@ -187,7 +186,6 @@ typedef struct df_history_t
 class t_state
 {
     public:
-        //! Constructor
         t_state();
 
         // All things public
index e62f26fcbf2bf30c841c7119ed34b906915dbfce..b4e5729e58b2562bf3046896c9f3bf4497d54882 100644 (file)
@@ -72,7 +72,6 @@ class AbstractOptionSection
         //! \cond libapi
         //! Initializes option properties with the given name.
         explicit AbstractOptionSection(const char *name) : name_(name) {}
-        //! Destructor
         virtual ~AbstractOptionSection() {}
         /*! \brief
          * Creates a storage object corresponding to this section.
index bd3090152bdd91063a7a4a429b7507a445866b08..79fb5c09450b39a1318524e5d8a650e4186239d5 100644 (file)
@@ -303,7 +303,6 @@ namespace
 class SingleRankChecker
 {
     public:
-        //! Constructor
         SingleRankChecker() : value_(false) {}
         /*! \brief Call this function for each possible condition
             under which a single rank is required, along with a string
index 1f9e0b5d01a6afe50f4c05bd32f370f1603c8d98..2a18e591743351f37e1e4b2c7ffcf73e8454c881 100644 (file)
@@ -61,10 +61,8 @@ extern const char *gtypes[egcNR+1];
 /*! \brief Molecules type data: atoms, interactions and exclusions */
 struct gmx_moltype_t
 {
-    /*! \brief Constructor */
     gmx_moltype_t();
 
-    /*! \brief Destructor */
     ~gmx_moltype_t();
 
     /*! \brief Deleted copy assignment operator to avoid (not) freeing pointers */
@@ -129,10 +127,8 @@ int getGroupType (const gmx_groups_t *group, int type, int atom);
  */
 struct gmx_mtop_t //NOLINT(clang-analyzer-optin.performance.Padding)
 {
-    /* Constructor */
     gmx_mtop_t();
 
-    /* Destructor */
     ~gmx_mtop_t();
 
     char                      **name; /* Name of the topology                 */
index 7f1b9ef9fe83e445672862d8bd13d698a14dc59f..f4692963a35c9fe1d123e70ea8b5fe1cb1a63ad1 100644 (file)
@@ -59,7 +59,6 @@ namespace gmx
 class ISerializer
 {
     public:
-        //! Destructor.
         virtual ~ISerializer() {}
         /*! \brief Returns whether the serializer is reading or
          * writing, because details like memory management vary
index cc3b8901348f519bdec92127a5380b6033c5bf95..720a30b89c3768ad17618e201c9bdc29e61e55e6 100644 (file)
@@ -139,7 +139,6 @@ int updateSharedValueWithTryLock()
 class DifferentTasksTest : public ::testing::TestWithParam<TaskType>
 {
     public:
-        //! Constructor
         DifferentTasksTest()
         {
             g_sharedValue = 0;
index 5c2f5294555f421d605371da93cd2625c86e300a..409ceaeacdb9d1edc72af65c1e60a21532f28078 100644 (file)
@@ -93,7 +93,6 @@ std::vector<std::string> getKeys(const Map &m)
     return keys;
 }
 
-//! Forward declaration
 class EnergyFrameReader;
 //! Convenience smart pointer typedef
 typedef std::unique_ptr<EnergyFrameReader> EnergyFrameReaderPtr;
index 96d7f7ea21ae9c231bce1795c3032c71039303c6..7eadeda2a082a98ae690cd995cecf919316a597c 100644 (file)
@@ -72,7 +72,6 @@ class MultiSimTest : public ::testing::Test,
                      public ::testing::WithParamInterface<const char *>
 {
     public:
-        //! Constructor
         MultiSimTest();
 
         /*! \brief Organize the .mdp file for this rank
index cb6658a807eb6c9d71f47017d481fd692b7af055..aed0eec18ccf7c70b960feb996564a5662a7ec87 100644 (file)
@@ -59,7 +59,6 @@
 namespace gmx
 {
 
-//! Forward declaration
 class TrajectoryFrame;
 
 namespace test