SYCL: Avoid using no_init read accessor in rocFFT master
authorAndrey Alekseenko <al42and@gmail.com>
Thu, 4 Nov 2021 17:37:42 +0000 (18:37 +0100)
committerAndrey Alekseenko <al42and@gmail.com>
Fri, 5 Nov 2021 15:59:14 +0000 (15:59 +0000)
Currently, hipSYCL ends up ignoring no_init property in this case.

But the SYCL standard does not permit such combination.

src/gromacs/fft/gpu_3dfft_sycl_rocfft.cpp

index 8e59c7fe11d18063696c4b0442d231f794595f65..c5942dd80724b24052eacc0943cbe1799842761f 100644 (file)
@@ -409,7 +409,7 @@ void Gpu3dFft::ImplSyclRocfft::perform3dFft(gmx_fft_direction dir, CommandEvent*
     }
     // Enqueue the 3D FFT work
     impl_->queue_.submit([&](cl::sycl::handler& cgh) {
-        auto inputGridAccessor = inputGrid->get_access(cgh, cl::sycl::read_only, cl::sycl::no_init);
+        auto inputGridAccessor = inputGrid->get_access(cgh, cl::sycl::read_only);
         auto outputGridAccessor = outputGrid->get_access(cgh, cl::sycl::write_only, cl::sycl::no_init);
         // Use a hipSYCL custom operation to access the native buffers
         // needed to call rocFFT