Extract IOptionsContainer from Options
authorTeemu Murtola <teemu.murtola@gmail.com>
Fri, 17 Jul 2015 10:29:06 +0000 (13:29 +0300)
committerGerrit Code Review <gerrit@gerrit.gromacs.org>
Sat, 25 Jul 2015 09:45:07 +0000 (11:45 +0200)
commitd140ff68d87ca3c962308fc03dadd4d99cdd9459
tree7a640e6293b56a5d0033ba4d762043a5e1d4b394
parent5750bfe806310856448a1e7baf46a7d648d1185e
Extract IOptionsContainer from Options

- Create a separate interface that declares addOption(), and make
  Options implement it.
- Change methods that took an Options just to call addOption() to take
  an instance of the new interface instead of a full Options object.
- Adjust documentation.

This isolates callers that only provide options from other details of
the options implementation, and allows further refactoring (that will
provide more implementations for this same interface).

Change-Id: I26d3f03602a8edd130d05231b3b0ee14b598ec8e
38 files changed:
docs/doxygen/user/analysisframework.md
share/template/template.cpp
src/gromacs/analysisdata/modules/plot.cpp
src/gromacs/analysisdata/modules/plot.h
src/gromacs/commandline/cmdlineoptionsmodule.h
src/gromacs/commandline/tests/cmdlinehelpmodule.cpp
src/gromacs/commandline/tests/cmdlinemodulemanagertest.h
src/gromacs/gmxpreprocess/insert-molecules.cpp
src/gromacs/options.h
src/gromacs/options/CMakeLists.txt
src/gromacs/options/filenameoptionmanager.cpp
src/gromacs/options/filenameoptionmanager.h
src/gromacs/options/ioptionscontainer.h [new file with mode: 0644]
src/gromacs/options/options.cpp
src/gromacs/options/options.h
src/gromacs/options/timeunitmanager.cpp
src/gromacs/options/timeunitmanager.h
src/gromacs/selection/selectioncollection.cpp
src/gromacs/selection/selectioncollection.h
src/gromacs/selection/selectionoption.h
src/gromacs/selection/tests/selectioncollection.cpp
src/gromacs/simd/tests/base.cpp
src/gromacs/trajectoryanalysis/analysismodule.h
src/gromacs/trajectoryanalysis/modules/angle.cpp
src/gromacs/trajectoryanalysis/modules/distance.cpp
src/gromacs/trajectoryanalysis/modules/freevolume.cpp
src/gromacs/trajectoryanalysis/modules/pairdist.cpp
src/gromacs/trajectoryanalysis/modules/rdf.cpp
src/gromacs/trajectoryanalysis/modules/sasa.cpp
src/gromacs/trajectoryanalysis/modules/select.cpp
src/gromacs/trajectoryanalysis/runnercommon.cpp
src/gromacs/trajectoryanalysis/runnercommon.h
src/gromacs/trajectoryanalysis/tests/test_selection.cpp
src/programs/mdrun/tests/moduletest.cpp
src/testutils/stringtest.cpp
src/testutils/testfilemanager.cpp
src/testutils/testoptions.cpp
src/testutils/testoptions.h