alexxy/gromacs.git
2 years agoConvert atomInfo to int64_t
Mark Abraham [Thu, 3 Jun 2021 08:26:22 +0000 (10:26 +0200)]
Convert atomInfo to int64_t

This ensures we can use bits from a 64-bit range if we ever need
that. Or easily switch to 32-bit range if that's advantageous.

Refs #4004

2 years agoRequire CUDA 11.0
Szilárd Páll [Fri, 4 Jun 2021 10:15:32 +0000 (10:15 +0000)]
Require CUDA 11.0

Also remove some cmake code that aided support for version <11.0.

Refs #3708

2 years agoMove useMts flag from forcerec to simulationWorkload
Szilárd Páll [Fri, 4 Jun 2021 06:46:49 +0000 (06:46 +0000)]
Move useMts flag from forcerec to simulationWorkload

2 years agoMake constraints and SETTLE tests backend-agnostic
Artem Zhmurov [Thu, 3 Jun 2021 20:23:35 +0000 (20:23 +0000)]
Make constraints and SETTLE tests backend-agnostic

2 years agoRemove useless charge-group work during repartitioning
Mark Abraham [Thu, 3 Jun 2021 17:35:14 +0000 (17:35 +0000)]
Remove useless charge-group work during repartitioning

2 years agoUpdate tested CUDA versions
Mark Abraham [Thu, 3 Jun 2021 16:03:23 +0000 (16:03 +0000)]
Update tested CUDA versions

2 years agoRemove preprocessor usage for atomInfo
Mark Abraham [Thu, 3 Jun 2021 14:58:26 +0000 (14:58 +0000)]
Remove preprocessor usage for atomInfo

2 years agoAdded QM input file name as command-line parameter for grompp
Dmitry Morozov [Thu, 3 Jun 2021 14:33:14 +0000 (14:33 +0000)]
Added QM input file name as command-line parameter for grompp

Part of #3172

2 years agoFix getLocalAtomCount()
Szilárd Páll [Thu, 3 Jun 2021 13:26:20 +0000 (15:26 +0200)]
Fix getLocalAtomCount()

Pass dd as pointer to avoid nullptr dereferencing introduced in
ba71b7526c22715aceb36586e76f2ae58c4a2461.

Refs #3915

2 years agoMinor pull code cleanup
Berk Hess [Thu, 3 Jun 2021 09:54:55 +0000 (11:54 +0200)]
Minor pull code cleanup

Replaced some pointer by references, removed some unnecessary struct,
converted a loop to range and converted some documentation to doxygen.

2 years agoAdd domainWorkload flags for CPU local force contributions
Szilárd Páll [Thu, 3 Jun 2021 07:36:24 +0000 (09:36 +0200)]
Add domainWorkload flags for CPU local force contributions

Part of #3913

2 years agoFree energy history modular checkpointing
Pascal Merz [Tue, 17 Nov 2020 01:14:32 +0000 (18:14 -0700)]
Free energy history modular checkpointing

This introduces a function that allows df_history_t objects to save to
and reset from modular simulator checkpoints. This allows elements
owning such an object to easily checkpoint it.

This also introduces a helper function to create CheckpointDataOperation
dependent ArrayRefs from C arrays.

2 years agoAdd a getter function for the local atom count
Szilárd Páll [Thu, 3 Jun 2021 08:18:40 +0000 (10:18 +0200)]
Add a getter function for the local atom count

Refs #3915

3 years agoRemove unneeded template keyword which trips up MSVC
Pascal Merz [Thu, 3 Jun 2021 01:32:19 +0000 (19:32 -0600)]
Remove unneeded template keyword which trips up MSVC

Solves part 1 of #4065

3 years agoSYCL: Update env. vars to select GPUs
Andrey Alekseenko [Wed, 2 Jun 2021 09:06:18 +0000 (12:06 +0300)]
SYCL: Update env. vars to select GPUs

SYCL_DEVICE_FILTER is supported in OneAPI releases, so we can safely
recommend it. Also added the ROCm string when compiled with hipSYCL.

3 years agoAdd notifications for MDModules that will be used in QMMM
Dmitry Morozov [Wed, 2 Jun 2021 09:41:44 +0000 (09:41 +0000)]
Add notifications for MDModules that will be used in QMMM

3 years agoRemoved GMX_CLANG_CUDA build using old versions
Mark Abraham [Wed, 2 Jun 2021 06:44:51 +0000 (08:44 +0200)]
Removed GMX_CLANG_CUDA build using old versions

Clarified that a release job was targetting clang as host-only
compiler, ie. not GMX_CLANG_CUDA.

Refs #3708

3 years agoMark a variable as unused in non-MPI build
Andrey Alekseenko [Tue, 1 Jun 2021 14:13:32 +0000 (17:13 +0300)]
Mark a variable as unused in non-MPI build

3 years agoFix gmx nmr -viol option
Eliane Briand [Mon, 31 May 2021 14:46:31 +0000 (16:46 +0200)]
Fix gmx nmr -viol option

Ref #4060

3 years agoFinish breaking up domdec_topology.cpp
Mark Abraham [Mon, 31 May 2021 15:32:14 +0000 (15:32 +0000)]
Finish breaking up domdec_topology.cpp

3 years agoIncrease const correctness in gmx_pme_send_parameters
ejjordan [Mon, 31 May 2021 09:36:09 +0000 (11:36 +0200)]
Increase const correctness in gmx_pme_send_parameters

Also switched to ArrayRef<const RVec> from pointer in one function
and removed an unused header.

3 years agoMove total bonded count to LocalTopologyChecker
Mark Abraham [Mon, 31 May 2021 10:14:22 +0000 (10:14 +0000)]
Move total bonded count to LocalTopologyChecker

3 years agoSplit localtopology from domdec_topology
Mark Abraham [Mon, 31 May 2021 09:05:50 +0000 (11:05 +0200)]
Split localtopology from domdec_topology

This is a separable responsibility and can go in its own
translation unit.

Refs #3887

3 years agoPartial renaming of cginfo to atom info
Mark Abraham [Mon, 31 May 2021 08:14:35 +0000 (08:14 +0000)]
Partial renaming of cginfo to atom info

3 years agoFix one more missing template declaration
Andrey Alekseenko [Sun, 30 May 2021 15:54:10 +0000 (18:54 +0300)]
Fix one more missing template declaration

Continuation of the work started in bf9b81c4 (MR !1652)

3 years agoIntroduce Andersen temperature coupling for modular simulator
Pascal Merz [Mon, 31 May 2021 00:10:49 +0000 (18:10 -0600)]
Introduce Andersen temperature coupling for modular simulator

This introduces the `andersen` and `andersen-massive` temperature coupling
for modular simulator. Since reshuffeling the velocities does require a
constraining step, the Andersen temperature coupling uses the composite
element to combine the Andersen element with a constraining element.

Refs #3423, refs #3417

3 years agoAdd nightly CI test on OneAPI + Intel GPU
Andrey Alekseenko [Mon, 31 May 2021 06:26:32 +0000 (06:26 +0000)]
Add nightly CI test on OneAPI + Intel GPU

3 years agoDisable false-positive warnings for ICPX 2021.2.0
Andrey Alekseenko [Fri, 28 May 2021 22:51:33 +0000 (01:51 +0300)]
Disable false-positive warnings for ICPX 2021.2.0

Not happening in open-source intel/llvm compiler.

While originally it was enough to disable them at include stage, in
2021.2 the warning is issued in the kernel itself, so we had to expand
its usage beyond gmxsycl.h.

3 years agoFix missing template declaration
Paul Bauer [Fri, 28 May 2021 08:55:23 +0000 (08:55 +0000)]
Fix missing template declaration

3 years agoCompute global bonded interaction count from system topology
Mark Abraham [Fri, 28 May 2021 07:32:08 +0000 (07:32 +0000)]
Compute global bonded interaction count from system topology

3 years agoReworked convert-tpr runtime extension
Eliane Briand [Fri, 28 May 2021 07:11:10 +0000 (07:11 +0000)]
Reworked convert-tpr runtime extension

3 years agoRemove orphaned code
Mark Abraham [Thu, 27 May 2021 12:41:24 +0000 (14:41 +0200)]
Remove orphaned code

This should have been removed in c17939744a88e but somehow it
survived long enough to move location. This should have failed
testing because optional std header is not included here, but
it somehow passed.

Now it is removed

Refs #3887

3 years agoMove reverse topology code to its own translation unit
Mark Abraham [Thu, 27 May 2021 09:48:39 +0000 (09:48 +0000)]
Move reverse topology code to its own translation unit

3 years agoAdd release notes about REMD with GPU update
Artem Zhmurov [Wed, 26 May 2021 11:48:01 +0000 (14:48 +0300)]
Add release notes about REMD with GPU update

REMD is now possible with GPU update, which should be noted in
release notes.

Feature enabled in 29c336cd0a518507c86094b08a447ec388afaad2

Refs #3997

3 years agoClean up simulator algorithm
Pascal Merz [Thu, 27 May 2021 08:55:14 +0000 (08:55 +0000)]
Clean up simulator algorithm

3 years agoRename GpuBonded into ListedForcesGpu
Artem Zhmurov [Wed, 26 May 2021 09:05:03 +0000 (12:05 +0300)]
Rename GpuBonded into ListedForcesGpu

The listed forces name describes better what the class is
doing and also follows the naming for other modules.

3 years agoDisable CUDA clang-tidy test
Paul Bauer [Thu, 27 May 2021 07:41:49 +0000 (09:41 +0200)]
Disable CUDA clang-tidy test

This is failing for some reason and needs proper fixing later.

3 years agoMove the code of what will later implement LocalTopologyChecker
Mark Abraham [Wed, 5 May 2021 06:53:36 +0000 (08:53 +0200)]
Move the code of what will later implement LocalTopologyChecker

Some common implementation functionality used in making
the reverse topology also needs to be exposed. Otherwise,
this is pure code movement with no functionality changes.

Refs #3887

3 years agoMoved PME-only ranks check to domain decomposition setup
Dmitry Morozov [Wed, 26 May 2021 15:01:42 +0000 (15:01 +0000)]
Moved PME-only ranks check to domain decomposition setup

3 years agoEliminate redundant GPU force reduction event dependency
Szilárd Páll [Wed, 26 May 2021 14:06:24 +0000 (14:06 +0000)]
Eliminate redundant GPU force reduction event dependency

CPU force transfers happen on the same strem as GPU reduction, so no explicit dependency is needed.

Additionally, due to a StatePropagatorDataGpu bug, whenever the force readiness event queried is not AtomLocality::All, an incorrect event is returned leading to circular dependency on force reduction, as described in #4032.

This change however does not fix the StatePropagatorDataGpu bug, but it should help avoiding workarounds for the new SYCL backend (#3932).

Refs #4032 #3988

3 years agoFix clang-format
Mark Abraham [Wed, 26 May 2021 08:39:19 +0000 (10:39 +0200)]
Fix clang-format

3 years agoRemove foreign energy groups from gmx_enerdata_t
ejjordan [Mon, 24 May 2021 15:38:49 +0000 (17:38 +0200)]
Remove foreign energy groups from gmx_enerdata_t

These members are only used for local storage and can be eliminated.

Added function to zero the energy group pair terms.

This will aid in further refactoring of the nonboded FEP kernels.

3 years agoMove t_forcetable and table enums to forcetable header
Joe Jordan [Wed, 26 May 2021 09:14:47 +0000 (09:14 +0000)]
Move t_forcetable and table enums to forcetable header

3 years agoImplement generic j-reduction in the nbnxm SYCL kernels
Szilárd Páll [Tue, 30 Mar 2021 13:24:08 +0000 (15:24 +0200)]
Implement generic j-reduction in the nbnxm SYCL kernels

This commit implements the generic j-reduction identical to the OpenCL
version of the same.

Also added a subGroupBarrier() helper which is needed for
correctness on the CUDA backend when targetting NVIDIA
architectures.

Refs #3934

3 years agoFix clang tidy version for CUDA
Paul Bauer [Wed, 26 May 2021 07:39:06 +0000 (07:39 +0000)]
Fix clang tidy version for CUDA

3 years agoIntroduce domain decomposition notifications
Pascal Merz [Wed, 26 May 2021 07:05:54 +0000 (07:05 +0000)]
Introduce domain decomposition notifications

3 years agoSplit expanded ensemble function
Pascal Merz [Fri, 21 May 2021 21:33:37 +0000 (15:33 -0600)]
Split expanded ensemble function

The expanded ensemble function was split into a part chosing a new
lambda state, and a second part updating the reference temperature
in the case of simulated tempering. To leave legacy paths unchanged,
the original function name has been maintained, which calls the two
parts. The function chosing a new lambda state is declared in the
header to allow modular simulator to call it separately.

This is pure refactoring (with the exception of moving a few variable
declarations to their initialization sites). Expanded ensemble is
covered by the new FEP tests.

This prepares introducing the expanded ensemble in modular simulator,
and is a first step towards #3848.

Refs #3417

3 years agoOnly Pass needed data to nonbonded param setup in forcerec
Joe Jordan [Tue, 25 May 2021 09:41:58 +0000 (09:41 +0000)]
Only Pass needed data to nonbonded param setup in forcerec

3 years agoAdd CUDA clang tidy build to CI
Paul Bauer [Fri, 21 May 2021 09:07:07 +0000 (11:07 +0200)]
Add CUDA clang tidy build to CI

Runs test script for pre-submit and full build nightly.

3 years agoApply clang-tidy-11 fixes to CUDA files
Paul Bauer [Mon, 24 May 2021 12:58:44 +0000 (12:58 +0000)]
Apply clang-tidy-11 fixes to CUDA files

3 years agoRemove dead members from gmx_pme_t
Joe Jordan [Mon, 24 May 2021 12:34:55 +0000 (12:34 +0000)]
Remove dead members from gmx_pme_t

3 years agoRemove forcerec from dispatchFreeEnergyKernel signature
Joe Jordan [Mon, 24 May 2021 11:53:02 +0000 (11:53 +0000)]
Remove forcerec from dispatchFreeEnergyKernel signature

3 years agoLet installed library options default to BUILD_SHARED_LIBS.
M. Eric Irrgang [Fri, 21 May 2021 15:02:15 +0000 (10:02 -0500)]
Let installed library options default to BUILD_SHARED_LIBS.

Fixes #4053

3 years agoRemove GMX_CONSTRVIR
Mark Abraham [Mon, 24 May 2021 03:58:19 +0000 (05:58 +0200)]
Remove GMX_CONSTRVIR

Simplifies handling of energy output by removing a feature that was
likely useful only during debugging yet incurred function-call
overhead every MD step even when not used.

Resolves previous TODO

Updates tests to no longer check such output while not changing
the numerical output previously written.

3 years agoAdd a const getter for the enerd struct to EnergyData
Pascal Merz [Tue, 17 Nov 2020 01:19:08 +0000 (18:19 -0700)]
Add a const getter for the enerd struct to EnergyData

This is not currently used, but will allow for more const-correctness
in upcoming changes.

3 years agoImplement Berendsen and c-rescale pressure coupling for modular simulator
Pascal Merz [Mon, 24 May 2021 04:27:50 +0000 (04:27 +0000)]
Implement Berendsen and c-rescale pressure coupling for modular simulator

3 years agoExpose DD distribution of free energy history
Pascal Merz [Tue, 17 Nov 2020 01:13:37 +0000 (18:13 -0700)]
Expose DD distribution of free energy history

To implement expanded ensemble, modular simulator needs to be able
to distribute the free energy history without initiating a full
t_state object. This exposes the required function to make it
available to the expanded ensemble modular simulator element.

Refs #3417, #3419

3 years agoIntroduce frequency for CompositeSimulatorElement
Pascal Merz [Mon, 7 Sep 2020 16:28:37 +0000 (10:28 -0600)]
Introduce frequency for CompositeSimulatorElement

This adds functionality to run a composite simulator element at a
prescribed frequency. This prepares the introduction of Andersen
thermostatting.

3 years agoWorkaround for a hipSYCL assertion error
Szilárd Páll [Fri, 21 May 2021 10:16:51 +0000 (10:16 +0000)]
Workaround for a hipSYCL assertion error

3 years agoLocalize variables in gmx_pme_do
Joe Jordan [Thu, 20 May 2021 23:29:01 +0000 (23:29 +0000)]
Localize variables in gmx_pme_do

3 years agoRemove GPU update restriction for replica exchange
Alan Gray [Tue, 18 May 2021 14:33:42 +0000 (07:33 -0700)]
Remove GPU update restriction for replica exchange

Ensures that the end-of-step D2H coordinate copy is active for replica
exchange steps, to allow the GPU update restriction to be relaxed.

3 years agoUse MessageStringCollector class to construct error messages
Artem Zhmurov [Thu, 20 May 2021 14:01:15 +0000 (14:01 +0000)]
Use MessageStringCollector class to construct error messages

3 years agoDisable ArrayRefDeathTests when building without assertions
Paul Bauer [Thu, 20 May 2021 07:57:58 +0000 (09:57 +0200)]
Disable ArrayRefDeathTests when building without assertions

Would otherwise lead to spurious failures.

3 years agoRemove inputrec from do_ewald
ejjordan [Wed, 19 May 2021 16:28:07 +0000 (18:28 +0200)]
Remove inputrec from do_ewald

Also rename some parameters more verbosely and remove a dead code
block.

3 years agoLocalize variables in ewald_LRcorrection
Joe Jordan [Thu, 20 May 2021 06:25:18 +0000 (06:25 +0000)]
Localize variables in ewald_LRcorrection

3 years agoFix clang-format
Artem Zhmurov [Wed, 19 May 2021 15:46:59 +0000 (18:46 +0300)]
Fix clang-format

Introduced in e3aaab14bcc05164ad6c82ac28d7dd1af99bd576

3 years agoSupport GPU update without constraints
Andrey Alekseenko [Wed, 19 May 2021 16:15:08 +0000 (16:15 +0000)]
Support GPU update without constraints

3 years agoMake TrotterSequence enum class
ejjordan [Mon, 17 May 2021 13:54:03 +0000 (15:54 +0200)]
Make TrotterSequence enum class

A subesquent MR can make an extended Trotter enum class, removing
dependence of coupling and update_vv headers on md_enums header.

3 years agoClean up some headers in mdlib
Joe Jordan [Wed, 19 May 2021 15:09:16 +0000 (15:09 +0000)]
Clean up some headers in mdlib

3 years agoRemove forcerec and inputrec from ewald_LRcorrection
ejjordan [Tue, 18 May 2021 18:19:54 +0000 (20:19 +0200)]
Remove forcerec and inputrec from ewald_LRcorrection

Only pass needed parameters to ewald_LRcorrection, instead of
entire forcerec and inputrec. This required also refactoring
EwaldBoxZScaler to only take needed parameters instead of a
whole inputrec.

Also made some names more verbose.

3 years agoAdd nullptr check in ArrayRef from array construction
Paul Bauer [Wed, 19 May 2021 11:33:56 +0000 (11:33 +0000)]
Add nullptr check in ArrayRef from array construction

3 years agoMake common Leap-Frog device code backend-agnostic
Artem Zhmurov [Wed, 19 May 2021 10:53:55 +0000 (10:53 +0000)]
Make common Leap-Frog device code backend-agnostic

3 years agoRemove forcerec from ewald_charge_correction
ejjordan [Tue, 18 May 2021 18:35:53 +0000 (20:35 +0200)]
Remove forcerec from ewald_charge_correction

Also renamed commrec to be more verbose.

3 years agoFix CMake 3.20 warnings when compiling with IntelLLVM
Andrey Alekseenko [Tue, 18 May 2021 19:54:23 +0000 (22:54 +0300)]
Fix CMake 3.20 warnings when compiling with IntelLLVM

Most work was done in 5d2d4769 (MR !1558), but we were still getting
warnings from the compiler compatibility checks. Nothing major, just
noise.

3 years agoRemove unused StatisticsStatus values
Andrey Alekseenko [Tue, 18 May 2021 11:41:49 +0000 (14:41 +0300)]
Remove unused StatisticsStatus values

The `enumValueToString(StatisticsStatus)` had the wrong order of
strings. But in fact most of these statuses were not used anyway, so we
can just remove the corresponding enum values altogether.

3 years agoFix several doxygen errors
Joe Jordan [Tue, 18 May 2021 10:50:09 +0000 (10:50 +0000)]
Fix several doxygen errors

3 years agoMove the stub for X buffer ops into OpenCL
Artem Zhmurov [Mon, 17 May 2021 10:01:57 +0000 (10:01 +0000)]
Move the stub for X buffer ops into OpenCL

3 years agoRefactor gmx_reverse_top_t
Mark Abraham [Fri, 14 May 2021 07:13:52 +0000 (09:13 +0200)]
Refactor gmx_reverse_top_t

Made the impl properly private, but to do so had to separate
the responsibility for checking the local topology, which
should never have been here.

This introduces two new headers in preparation for splitting up
domdec_topology.cpp into several parts that can then have their own
headers. But first gmx_reverse_top_t has to be properly encapsulated.

Refs #3887

3 years agoMake NBNXM force getter available in all backends
Artem Zhmurov [Mon, 17 May 2021 07:58:53 +0000 (07:58 +0000)]
Make NBNXM force getter available in all backends

3 years agoUse InheritParentConfig: true in clang-tidy files
Paul Bauer [Fri, 14 May 2021 13:05:27 +0000 (15:05 +0200)]
Use InheritParentConfig: true in clang-tidy files

Removes duplication between files in test directories where it can be
avoided.

3 years agoUse appendIf(..) method of MessageStringCollector where it is relevant
Artem Zhmurov [Thu, 13 May 2021 08:41:17 +0000 (11:41 +0300)]
Use appendIf(..) method of MessageStringCollector where it is relevant

Refs #3886

3 years agoRemove extra device force getter from NBNXM
Artem Zhmurov [Wed, 12 May 2021 08:16:47 +0000 (11:16 +0300)]
Remove extra device force getter from NBNXM

Having two getters for the same device buffer is confusing and
polutes the name space. This removes the extra getter and
change to the calls to the other one where it was used.

Refs #2608

3 years agoAdd appendIf(..) method and tests for MessageStringCollector
Artem Zhmurov [Thu, 13 May 2021 08:06:19 +0000 (11:06 +0300)]
Add appendIf(..) method and tests for MessageStringCollector

The messages are usually added conditionally, which makes
it more natural to use msc.appendIf(conditional, message) as
compared to if(conditional) { msc.append(message); }.

Also adds tests for basic functionality of the class and
renames the files according to conventions.

Refs #3886

3 years agoDecouple update group handling from domain decomposition module
Mark Abraham [Thu, 13 May 2021 07:36:56 +0000 (07:36 +0000)]
Decouple update group handling from domain decomposition module

3 years agoAdd SYCL implementation of X/V scale kernel
Andrey Alekseenko [Tue, 27 Apr 2021 21:19:15 +0000 (00:19 +0300)]
Add SYCL implementation of X/V scale kernel

Refs #3929

3 years agoMake common Update-Constraints code backend-agnostic
Artem Zhmurov [Tue, 11 May 2021 11:25:26 +0000 (11:25 +0000)]
Make common Update-Constraints code backend-agnostic

3 years agoName the MDRun FEP test binary consistently
Artem Zhmurov [Tue, 11 May 2021 06:05:58 +0000 (09:05 +0300)]
Name the MDRun FEP test binary consistently

3 years agoRemove GMX_FORCE_DO_NOT_NEED_NORMAL_FORCE legacy flag in do_force()
Szilárd Páll [Tue, 11 May 2021 10:19:42 +0000 (10:19 +0000)]
Remove GMX_FORCE_DO_NOT_NEED_NORMAL_FORCE legacy flag in do_force()

3 years agoAdd test for single residue chain
Paul Bauer [Tue, 11 May 2021 09:51:13 +0000 (09:51 +0000)]
Add test for single residue chain

3 years agoFix clang-format
Artem Zhmurov [Tue, 11 May 2021 07:46:17 +0000 (10:46 +0300)]
Fix clang-format

Introduced in 6d002ec667c955c5137acdad74663bdbc1712f2f

3 years agoFix conditional in assertion
Artem Zhmurov [Tue, 11 May 2021 05:57:07 +0000 (08:57 +0300)]
Fix conditional in assertion

The B-charges should be defined to use FEP in PME. The condition
was changed to the opposite in fdac5efa5ed51dd9b8486ca35227708b62fb08ef

3 years agoApply more clang-tidy-11
Mark Abraham [Tue, 11 May 2021 08:31:47 +0000 (08:31 +0000)]
Apply more clang-tidy-11

3 years agoFix compiler warning and use static_assert
Artem Zhmurov [Tue, 11 May 2021 05:34:06 +0000 (08:34 +0300)]
Fix compiler warning and use static_assert

1. The compiler assumes that GMX_GPU_CUDA and GMX_GPU_SYCL
   may be bit-fields and thus issue a warning if the logical
   or is used (constant-logical-operand). Casting them to
   booleans supresses the warning.
2. Change to use static_assert instead of the GMX_RELEASE_ASSERT
   because this code on a hot path.

3 years agoEliminate duplicate CPU->GPU copy of x
Szilárd Páll [Wed, 21 Apr 2021 17:48:04 +0000 (19:48 +0200)]
Eliminate duplicate CPU->GPU copy of x

x is copied to the GPU for buffer ops or PME as well as prior to GPU
update on search steps which leads to a duplicate copying which is
addressed in this change.

Fixes #4033
Refs #3988

3 years agoAdd SYCL implementation of GPU F buffer operations
Andrey Alekseenko [Tue, 11 May 2021 07:16:38 +0000 (07:16 +0000)]
Add SYCL implementation of GPU F buffer operations

3 years agoApply clang-format-11
Mark Abraham [Mon, 10 May 2021 13:36:44 +0000 (15:36 +0200)]
Apply clang-format-11

This is better than slowly dribbling changes all over the
code base

3 years agoRename pdb2gmx tests
Mark Abraham [Tue, 11 May 2021 05:02:52 +0000 (05:02 +0000)]
Rename pdb2gmx tests

3 years agoFix harmless bug in nonbonded FEP tests
Joe Jordan [Mon, 10 May 2021 20:31:19 +0000 (20:31 +0000)]
Fix harmless bug in nonbonded FEP tests

3 years agoAdd SYCL implementation of GPU X buffer operations
Andrey Alekseenko [Mon, 10 May 2021 20:09:53 +0000 (20:09 +0000)]
Add SYCL implementation of GPU X buffer operations

3 years agoMake GPU X buffer ops platform-agnostic
Andrey Alekseenko [Mon, 10 May 2021 13:22:53 +0000 (13:22 +0000)]
Make GPU X buffer ops platform-agnostic