Fix clang-tidy warnings for clang 7
authorRoland Schulz <roland.schulz@intel.com>
Wed, 19 Sep 2018 19:57:15 +0000 (12:57 -0700)
committerMark Abraham <mark.j.abraham@gmail.com>
Fri, 21 Sep 2018 08:08:28 +0000 (10:08 +0200)
commitefaaccd4e92949920a4661c6bfb5250105eb88be
tree5021a8a302cbde712066d04884cfb215d3e71736
parent564a67c0872ad00cd314d69029dac8e3fde1b471
Fix clang-tidy warnings for clang 7

Disable clang-analyzer because we run analyzer as seperate job.
Disable cppcoreguidelines-avoid-goto because it is easy to spot
in code-review and has very rare good uses.

Change-Id: Ibfeb8ba6b14012b0079e7eef15282e0e2b6538fc
38 files changed:
admin/builds/pre-submit-matrix.txt
docs/dev-manual/tools.rst
src/.clang-tidy
src/.clang-tidy.new.code
src/gromacs/analysisdata/modules/plot.cpp
src/gromacs/awh/grid.cpp
src/gromacs/awh/tests/bias.cpp
src/gromacs/commandline/pargs.cpp
src/gromacs/domdec/domdec_topology.cpp
src/gromacs/fileio/matio.cpp
src/gromacs/fileio/pdbio.cpp
src/gromacs/gmxana/gmx_dipoles.cpp
src/gromacs/gmxana/gmx_genion.cpp
src/gromacs/gmxana/gmx_msd.cpp
src/gromacs/gmxana/gmx_trjcat.cpp
src/gromacs/gmxana/pp2shift.cpp
src/gromacs/gmxlib/nonbonded/.clang-tidy
src/gromacs/gmxpreprocess/pdb2top.cpp
src/gromacs/hardware/identifyavx512fmaunits.cpp
src/gromacs/listed-forces/pairs.cpp
src/gromacs/listed-forces/position-restraints.cpp
src/gromacs/math/functions.h
src/gromacs/mdlib/coupling.cpp
src/gromacs/mdlib/nbnxn_kernels/nbnxn_kernel_gpu_ref.cpp
src/gromacs/pulling/pullutil.cpp
src/gromacs/selection/params.cpp
src/gromacs/selection/selelem.cpp
src/gromacs/simd/scalar/scalar.h
src/gromacs/tables/cubicsplinetable.cpp
src/gromacs/tables/quadraticsplinetable.cpp
src/gromacs/tables/splineutil.cpp
src/gromacs/topology/atomprop.cpp
src/gromacs/trajectoryanalysis/runnercommon.cpp
src/gromacs/utility/bitmask.h
src/gromacs/utility/futil.cpp
src/gromacs/utility/stringutil.cpp
src/programs/mdrun/tests/rerun.cpp
src/testutils/testasserts.h