Remove PrivateImplPointer in favour of std::unique_ptr
authorMark Abraham <mark.j.abraham@gmail.com>
Fri, 29 Jan 2021 12:11:02 +0000 (13:11 +0100)
committerMark Abraham <mark.j.abraham@gmail.com>
Fri, 29 Jan 2021 13:22:23 +0000 (14:22 +0100)
commit8bfd8dcf84d26587db444f6b00e797a6073c1d3c
tree7434265b24a585cbf64611fc39c4816b0efa1f8c
parentd48c7e71e58875d79926b6ef5a13f1f89dd2ec50
Remove PrivateImplPointer in favour of std::unique_ptr

The single remaining advantage (help with const correctness in an
unlikely corner case) is outweighed by the disadvantages of
using a custom solution where a generic one would do.

Fixes #3684
126 files changed:
src/api/cpp/tests/restraint.cpp
src/gromacs/analysisdata/abstractdata.h
src/gromacs/analysisdata/analysisdata.h
src/gromacs/analysisdata/datamodulemanager.h
src/gromacs/analysisdata/datastorage.cpp
src/gromacs/analysisdata/datastorage.h
src/gromacs/analysisdata/modules/average.h
src/gromacs/analysisdata/modules/displacement.h
src/gromacs/analysisdata/modules/histogram.h
src/gromacs/analysisdata/modules/lifetime.h
src/gromacs/analysisdata/modules/plot.h
src/gromacs/analysisdata/tests/mock_datamodule.h
src/gromacs/applied_forces/densityfitting/densityfittingforceprovider.h
src/gromacs/commandline/cmdlinehelpcontext.h
src/gromacs/commandline/cmdlinehelpmodule.cpp
src/gromacs/commandline/cmdlinehelpmodule.h
src/gromacs/commandline/cmdlinehelpwriter.h
src/gromacs/commandline/cmdlinemodule.h
src/gromacs/commandline/cmdlinemodulemanager.h
src/gromacs/commandline/cmdlineparser.h
src/gromacs/commandline/cmdlineprogramcontext.h
src/gromacs/commandline/shellcompletions.h
src/gromacs/commandline/tests/cmdlinemodulemanagertest.h
src/gromacs/coordinateio/outputadaptercontainer.h
src/gromacs/correlationfunctions/tests/correlationdataset.h
src/gromacs/domdec/builder.h
src/gromacs/domdec/gpuhaloexchange.h
src/gromacs/domdec/localatomsetmanager.h
src/gromacs/essentialdynamics/edsam.h
src/gromacs/ewald/pme_coordinate_receiver_gpu.h
src/gromacs/ewald/pme_force_sender_gpu.h
src/gromacs/ewald/pme_gpu_program_impl.h
src/gromacs/ewald/pme_pp_comm_gpu.h
src/gromacs/fileio/mrcdensitymap.h
src/gromacs/gmxpreprocess/gpp_atomtype.h
src/gromacs/gmxpreprocess/gpp_bond_atomtype.h
src/gromacs/gpu_utils/device_context.h
src/gromacs/gpu_utils/device_stream.h
src/gromacs/gpu_utils/device_stream_manager.h
src/gromacs/imd/imd.h
src/gromacs/listed_forces/gpubonded.h
src/gromacs/math/coordinatetransformation.h
src/gromacs/math/densityfit.h
src/gromacs/math/densityfittingforce.h
src/gromacs/math/gausstransform.h
src/gromacs/mdlib/constr.h
src/gromacs/mdlib/gpuforcereduction.h
src/gromacs/mdlib/leapfrog_gpu.h
src/gromacs/mdlib/lincs_gpu.cuh
src/gromacs/mdlib/update.h
src/gromacs/mdlib/update_constrain_gpu.h
src/gromacs/mdlib/vsite.h
src/gromacs/mdrun/mdmodules.h
src/gromacs/mdtypes/forcebuffers.h
src/gromacs/mdtypes/iforceprovider.h
src/gromacs/mdtypes/state_propagator_data_gpu.h
src/gromacs/mdtypes/state_propagator_data_gpu_impl.h
src/gromacs/onlinehelp/helpformat.h
src/gromacs/onlinehelp/helpmanager.h
src/gromacs/onlinehelp/helptopic.h
src/gromacs/onlinehelp/helpwritercontext.cpp
src/gromacs/onlinehelp/helpwritercontext.h
src/gromacs/onlinehelp/rstparser.h
src/gromacs/options/abstractoption.h
src/gromacs/options/abstractoptionstorage.h
src/gromacs/options/abstractsection.h
src/gromacs/options/filenameoptionmanager.h
src/gromacs/options/optionmanagercontainer.h
src/gromacs/options/options.h
src/gromacs/options/options_impl.h
src/gromacs/options/optionsassigner.h
src/gromacs/options/optionsection.h
src/gromacs/options/optionsvisitor.h
src/gromacs/options/timeunitmanager.h
src/gromacs/pbcutil/com.h
src/gromacs/pulling/pull_rotation.h
src/gromacs/random/exponentialdistribution.h
src/gromacs/random/gammadistribution.h
src/gromacs/random/normaldistribution.h
src/gromacs/random/tabulatednormaldistribution.h
src/gromacs/random/threefry.h
src/gromacs/random/uniformintdistribution.h
src/gromacs/random/uniformrealdistribution.h
src/gromacs/selection/nbsearch.cpp
src/gromacs/selection/nbsearch.h
src/gromacs/selection/poscalc.h
src/gromacs/selection/selection.h
src/gromacs/selection/selectioncollection.h
src/gromacs/selection/selectionoptionbehavior.h
src/gromacs/selection/selectionoptionmanager.h
src/gromacs/selection/selhelp.cpp
src/gromacs/selection/symrec.h
src/gromacs/simd/simd.h
src/gromacs/tables/cubicsplinetable.h
src/gromacs/tables/quadraticsplinetable.h
src/gromacs/topology/atomprop.h
src/gromacs/topology/atomsbuilder.h
src/gromacs/topology/residuetypes.h
src/gromacs/trajectoryanalysis/analysismodule.h
src/gromacs/trajectoryanalysis/analysissettings.h
src/gromacs/trajectoryanalysis/modules/angle.cpp
src/gromacs/trajectoryanalysis/modules/surfacearea.h
src/gromacs/trajectoryanalysis/runnercommon.h
src/gromacs/trajectoryanalysis/tests/moduletest.h
src/gromacs/utility.h
src/gromacs/utility/classhelpers.h
src/gromacs/utility/datafilefinder.h
src/gromacs/utility/directoryenumerator.h
src/gromacs/utility/filestream.h
src/gromacs/utility/inmemoryserializer.h
src/gromacs/utility/keyvaluetreetransform.h
src/gromacs/utility/loggerbuilder.h
src/gromacs/utility/messagestringcollector.h
src/gromacs/utility/textreader.h
src/gromacs/utility/textwriter.h
src/programs/mdrun/tests/moduletest.h
src/testutils/include/testutils/cmdlinetest.h
src/testutils/include/testutils/interactivetest.h
src/testutils/include/testutils/loggertest.h
src/testutils/include/testutils/refdata.h
src/testutils/include/testutils/stdiohelper.h
src/testutils/include/testutils/stringtest.h
src/testutils/include/testutils/test_device.h
src/testutils/include/testutils/testfilemanager.h
src/testutils/include/testutils/testfileredirector.h
src/testutils/testoptions.cpp