Revert size to be unsigned for ArrayRef
authorRoland Schulz <roland.schulz@intel.com>
Wed, 6 Feb 2019 00:08:49 +0000 (16:08 -0800)
committerMark Abraham <mark.j.abraham@gmail.com>
Thu, 7 Feb 2019 10:42:09 +0000 (11:42 +0100)
commit55c76c88c4d65b5f2e9da8cda311bb4e90691980
tree87574037cb6a998a45e11b7b962de1ada5874111
parent35d429a0bdd16f216bcc055c5c4018a10d0e02f1
Revert size to be unsigned for ArrayRef

Given the decision for std::span to be signed this became
inconsistent with future C++ while already being inconsistent
with std::vector. The goal of the original change, to have
signed variables for all arithmetic including loop indices,
can be achieve by using ssize everwhere arithmethic is used.
ssize is both available as free function (also for std::vector)
and member function.

Related #2826

Change-Id: Icc5d0f9561c610cbce34c575d268171e9890ca9c
43 files changed:
docs/dev-manual/language-features.rst
src/gromacs/awh/biasstate.cpp
src/gromacs/awh/biaswriter.cpp
src/gromacs/awh/coordstate.cpp
src/gromacs/awh/correlationhistory.cpp
src/gromacs/awh/correlationtensor.h
src/gromacs/awh/tests/biasstate.cpp
src/gromacs/domdec/collect.cpp
src/gromacs/domdec/domdec_topology.cpp
src/gromacs/domdec/partition.cpp
src/gromacs/domdec/redistribute.cpp
src/gromacs/ewald/tests/pmetestcommon.cpp
src/gromacs/fileio/readinp.cpp
src/gromacs/fileio/tngio.cpp
src/gromacs/gmxana/gmx_densorder.cpp
src/gromacs/gmxana/gmx_eneconv.cpp
src/gromacs/gmxana/gmx_hydorder.cpp
src/gromacs/gmxana/gmx_make_ndx.cpp
src/gromacs/gmxana/gmx_nmeig.cpp
src/gromacs/gmxana/gmx_trjcat.cpp
src/gromacs/gmxana/thermochemistry.cpp
src/gromacs/gmxpreprocess/readir.cpp
src/gromacs/math/tests/testarrayrefs.h
src/gromacs/mdlib/calc_verletbuf.cpp
src/gromacs/mdlib/constr.h
src/gromacs/mdlib/force.cpp
src/gromacs/mdlib/forcerec.cpp
src/gromacs/mdlib/qmmm.cpp
src/gromacs/mdlib/updategroups.cpp
src/gromacs/mdlib/updategroupscog.cpp
src/gromacs/mdlib/vsite.cpp
src/gromacs/mdrun/multisim.cpp
src/gromacs/mdtypes/state.cpp
src/gromacs/pbcutil/pbc.cpp
src/gromacs/pulling/pull.cpp
src/gromacs/pulling/pull_rotation.cpp
src/gromacs/pulling/pullutil.cpp
src/gromacs/selection/tests/selectioncollection.cpp
src/gromacs/selection/tests/toputils.cpp
src/gromacs/topology/index.cpp
src/gromacs/topology/mtop_util.cpp
src/gromacs/topology/topology.cpp
src/gromacs/utility/arrayref.h