Update clang-tidy to clang version 8
authorMark Abraham <mark.j.abraham@gmail.com>
Sat, 6 Jul 2019 18:37:45 +0000 (20:37 +0200)
committerMark Abraham <mark.j.abraham@gmail.com>
Fri, 23 Aug 2019 09:20:13 +0000 (11:20 +0200)
commit658819431c0dabdb13ef01f32bf59e0c0eca82ff
treec966f391ee1069a64e56fe287468aa23d52ac774
parentd25d8cbc8ca972974256476d622e4d4c8909fd4e
Update clang-tidy to clang version 8

Some new warnings are well intentioned, but not practical to turn on
in GROMACS given the limited suppression capabilities.

Rationales for suppressions of new warnings can be found in
src/.clang-tidy

Change-Id: I857d3790450e33a669c6a68ad846cae3783875e7
89 files changed:
docs/dev-manual/build-system.rst
docs/dev-manual/tools.rst
src/.clang-tidy
src/.clang-tidy.new.code
src/external/.clang-tidy
src/gromacs/analysisdata/abstractdata.cpp
src/gromacs/analysisdata/abstractdata.h
src/gromacs/analysisdata/datamodulemanager.cpp
src/gromacs/analysisdata/datamodulemanager.h
src/gromacs/awh/pointstate.h
src/gromacs/coordinateio/tests/coordinate_test.h
src/gromacs/domdec/hashedmap.h
src/gromacs/domdec/redistribute.cpp
src/gromacs/fft/fft.cpp
src/gromacs/fft/fft_fftpack.cpp
src/gromacs/fileio/tngio.cpp
src/gromacs/gmxana/gmx_nmeig.cpp
src/gromacs/gmxana/gmx_nmr.cpp
src/gromacs/gmxana/gmx_nmtraj.cpp
src/gromacs/gmxana/gmx_order.cpp
src/gromacs/gmxana/gmx_potential.cpp
src/gromacs/gmxana/gmx_rms.cpp
src/gromacs/gmxana/gmx_rmsdist.cpp
src/gromacs/gmxana/gmx_rotacf.cpp
src/gromacs/gmxana/gmx_vanhove.cpp
src/gromacs/gmxpreprocess/gen_vsite.cpp
src/gromacs/gmxpreprocess/grompp.cpp
src/gromacs/gmxpreprocess/pdb2gmx.cpp
src/gromacs/gmxpreprocess/readir.cpp
src/gromacs/gmxpreprocess/toppush.cpp
src/gromacs/gmxpreprocess/vsite_parm.cpp
src/gromacs/hardware/cpuinfo.cpp
src/gromacs/hardware/hardwaretopology.cpp
src/gromacs/math/gausstransform.cpp
src/gromacs/math/gausstransform.h
src/gromacs/math/tests/functions.cpp
src/gromacs/math/vec.h
src/gromacs/mdlib/calc_verletbuf.cpp
src/gromacs/mdlib/constr.cpp
src/gromacs/mdlib/constr.h
src/gromacs/mdlib/mdebin_bar.cpp
src/gromacs/mdlib/qmmm.cpp
src/gromacs/mdlib/sim_util.cpp
src/gromacs/mdlib/tests/constr.cpp
src/gromacs/mdlib/tests/constrtestdata.cpp
src/gromacs/mdlib/tests/constrtestrunners.cpp
src/gromacs/mdlib/tests/energyoutput.cpp
src/gromacs/mdlib/tests/settletestdata.cpp
src/gromacs/mdlib/updategroupscog.cpp
src/gromacs/mdrun/minimize.cpp
src/gromacs/mdrun/runner.cpp
src/gromacs/mdrun/runner.h
src/gromacs/nbnxm/atomdata.cpp
src/gromacs/nbnxm/grid.cpp
src/gromacs/nbnxm/gridset.h
src/gromacs/nbnxm/kerneldispatch.cpp
src/gromacs/nbnxm/kernels_reference/kernel_gpu_ref.cpp
src/gromacs/nbnxm/kernels_reference/kernel_ref_inner.h
src/gromacs/nbnxm/kernels_simd_2xmm/kernel_inner.h
src/gromacs/nbnxm/kernels_simd_2xmm/kernel_outer.h
src/gromacs/nbnxm/kernels_simd_4xm/kernel_inner.h
src/gromacs/nbnxm/kernels_simd_4xm/kernel_outer.h
src/gromacs/nbnxm/pairlist.cpp
src/gromacs/nbnxm/pairlistsets.h
src/gromacs/random/tabulatednormaldistribution.h
src/gromacs/restraint/manager.cpp
src/gromacs/restraint/manager.h
src/gromacs/selection/indexutil.cpp
src/gromacs/simd/simd.h
src/gromacs/topology/atomprop.cpp
src/gromacs/topology/atomprop.h
src/gromacs/topology/block.h
src/gromacs/topology/forcefieldparameters.cpp
src/gromacs/topology/idef.h
src/gromacs/topology/index.cpp
src/gromacs/topology/residuetypes.cpp
src/gromacs/topology/residuetypes.h
src/gromacs/topology/tests/exclusionblocks.cpp
src/gromacs/topology/topology.cpp
src/gromacs/trajectory/energyframe.cpp
src/gromacs/trajectory/energyframe.h
src/gromacs/utility/binaryinformation.cpp
src/gromacs/utility/cstringutil.cpp
src/gromacs/utility/fatalerror.cpp
src/gromacs/utility/keyvaluetree.h
src/gromacs/utility/strdb.cpp
src/testutils/testasserts.cpp
src/testutils/testasserts.h
src/testutils/textblockmatchers.cpp