Enable more warnings for Clang 6
authorRoland Schulz <roland.schulz@intel.com>
Sun, 1 Jul 2018 21:24:36 +0000 (14:24 -0700)
committerRoland Schulz <roland.schulz@intel.com>
Wed, 4 Jul 2018 16:11:21 +0000 (18:11 +0200)
commitddc2297bba8efc4007bc58ac687b3cf8ab69368d
treef5a04eb9768b8796228fc25002cab6a7983501c3
parent296935c999076ec1d4f9c77578459ad2127c0a66
Enable more warnings for Clang 6

Many useful clang warnings are not enabled with -Wall -Wextra.
Enable all with -Weverything and document which are disabled
for what reason. Only do this for the most recent released
version to avoid having false postives from multiple
versions.

Fix the 9 of the least common issued warnings:
class-varargs range-loop-analysis
unused-template implicit-fallthrough non-virtual-dtor
zero-as-null-pointer-constant
header-hygiene unused-member-function missing-noreturn

Change-Id: I70df6553aa715cbd99963dd66d4b4bbd55ffc64d
38 files changed:
cmake/gmxCFlags.cmake
src/gromacs/CMakeLists.txt
src/gromacs/applied-forces/electricfield.cpp
src/gromacs/domdec/domdec.cpp
src/gromacs/domdec/domdec.h
src/gromacs/domdec/redistribute.cpp
src/gromacs/ewald/pme-simd4.h
src/gromacs/ewald/pme-spline-work.h
src/gromacs/ewald/pme.cpp
src/gromacs/fileio/checkpoint.cpp
src/gromacs/fileio/gmxfio-xdr.cpp
src/gromacs/fileio/trxio.cpp
src/gromacs/gmxana/gmx_bar.cpp
src/gromacs/gmxlib/network.h
src/gromacs/gmxpreprocess/insert-molecules.cpp
src/gromacs/gpu_utils/gpu_utils.h
src/gromacs/mdlib/broadcaststructs.h
src/gromacs/mdlib/constr.h
src/gromacs/mdlib/nbnxn_internal.h
src/gromacs/mdlib/nbnxn_kernels/simd_2xnn/nbnxn_kernel_simd_2xnn_common.h
src/gromacs/mdlib/nbnxn_kernels/simd_2xnn/nbnxn_kernel_simd_2xnn_outer.h
src/gromacs/mdlib/nbnxn_kernels/simd_2xnn/nbnxn_kernel_simd_2xnn_prune.cpp
src/gromacs/mdlib/nbnxn_kernels/simd_4xn/nbnxn_kernel_simd_4xn_common.h
src/gromacs/mdlib/nbnxn_kernels/simd_4xn/nbnxn_kernel_simd_4xn_outer.h
src/gromacs/mdlib/nbnxn_kernels/simd_4xn/nbnxn_kernel_simd_4xn_prune.cpp
src/gromacs/mdlib/nbnxn_search.cpp
src/gromacs/mdlib/nbnxn_search_simd_2xnn.h
src/gromacs/mdlib/nbnxn_search_simd_4xn.h
src/gromacs/mdlib/qmmm.cpp
src/gromacs/mdlib/sim_util.cpp
src/gromacs/mdlib/wall.cpp
src/gromacs/options/abstractsection.h
src/gromacs/pbcutil/pbc-simd.h
src/gromacs/selection/sm_position.cpp
src/gromacs/utility/arrayref.h
src/gromacs/utility/ikeyvaluetreeerror.h
src/gromacs/utility/keyvaluetreeserializer.cpp
src/gromacs/utility/path.h