Remove duplication in version info target creation

[alexxy/gromacs.git] / cmake / gmxVersionInfo.cmake

diff --git a/cmake/gmxVersionInfo.cmake b/cmake/gmxVersionInfo.cmake
index 7b8d08402f9374a98f8a63bb896650140d1b88fc..6430211f29ef31c8f5be264db98ab49345e91246 100644 (file)
--- a/cmake/gmxVersionInfo.cmake
+++ b/cmake/gmxVersionInfo.cmake
@@ -256,6 +256,8 @@ if (GMX_GIT_VERSION_INFO)
     endif()
 endif()
 
+include(gmxCustomCommandUtilities)
+
 # The first two are also for use outside this file, encapsulating the details
 # of how to use the generated VersionInfo.cmake.
 set(VERSION_INFO_CMAKE_FILE   ${PROJECT_BINARY_DIR}/VersionInfo.cmake)
@@ -310,52 +312,17 @@ if (GMX_GIT_VERSION_INFO)
     # All targets added by gmx_configure_version_file() use the information
     # from this script to get their variables from, removing the need to run
     # git multiple times and simplifying reuse for other purposes.
-    #
-    # Ninja requires all generated files mentioned in dependencies of custom
-    # commands (in gmx_configure_version_info()) to be actually mentioned in
-    # the build system, and luckily add_custom_command() makes that possible.
-    # But it seems impossible to create a robust custom command that would be
-    # always run, so other generators that do not have this constraint simply
-    # use an add_custom_target().
-    if (CMAKE_GENERATOR STREQUAL "Ninja")
-        # The second, phony file is never created, so the rule is always
-        # triggered again.  TODO: Figure out why this works, even though ninja
-        # very eagerly complains about missing files.
-        # This unfortunately does not work with the make generator, as
-        # the non-existent second file causes some part of the generated system
-        # erase the first file at the beginning of every build, causing a full
-        # rebuild of the dependencies.
-        add_custom_command(OUTPUT ${VERSION_INFO_CMAKE_FILE} git-version-phony
-            COMMAND ${CMAKE_COMMAND}
-                -D GIT_EXECUTABLE=${GIT_EXECUTABLE}
-                -D PROJECT_VERSION=${GMX_VERSION_STRING}
-                -D PROJECT_SOURCE_DIR=${PROJECT_SOURCE_DIR}
-                -D VERSION_CMAKEIN=${VERSION_INFO_CMAKEIN_FILE_PARTIAL}
-                -D VERSION_OUT=${VERSION_INFO_CMAKE_FILE}
-                -P ${CMAKE_CURRENT_LIST_DIR}/gmxGenerateVersionInfo.cmake
-            WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
-            COMMENT "Generating git version information"
-            VERBATIM)
-        # The generated Ninja build system would probably work fine even
-        # without this target, but CMake requires all custom commands to belong
-        # to a target in the same CMakeLists.txt to generate anything for them.
-        add_custom_target(git-version-info DEPENDS ${VERSION_INFO_CMAKE_FILE})
-    else()
-        # For other generators, a target-level dependency on git-version-info
-        # ensures that VERSION_INFO_CMAKE_FILE is created before the dependent
-        # target's dependencies are even evaluated.
-        add_custom_target(git-version-info
-            COMMAND ${CMAKE_COMMAND}
-                -D GIT_EXECUTABLE=${GIT_EXECUTABLE}
-                -D PROJECT_VERSION=${GMX_VERSION_STRING}
-                -D PROJECT_SOURCE_DIR=${PROJECT_SOURCE_DIR}
-                -D VERSION_CMAKEIN=${VERSION_INFO_CMAKEIN_FILE_PARTIAL}
-                -D VERSION_OUT=${VERSION_INFO_CMAKE_FILE}
-                -P ${CMAKE_CURRENT_LIST_DIR}/gmxGenerateVersionInfo.cmake
-            WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
-            COMMENT "Generating git version information"
-            VERBATIM)
-    endif()
+    gmx_add_custom_output_target(git-version-info RUN_ALWAYS
+        OUTPUT ${VERSION_INFO_CMAKE_FILE}
+        COMMAND ${CMAKE_COMMAND}
+            -D GIT_EXECUTABLE=${GIT_EXECUTABLE}
+            -D PROJECT_VERSION=${GMX_VERSION_STRING}
+            -D PROJECT_SOURCE_DIR=${PROJECT_SOURCE_DIR}
+            -D VERSION_CMAKEIN=${VERSION_INFO_CMAKEIN_FILE_PARTIAL}
+            -D VERSION_OUT=${VERSION_INFO_CMAKE_FILE}
+            -P ${CMAKE_CURRENT_LIST_DIR}/gmxGenerateVersionInfo.cmake
+        WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
+        COMMENT "Generating git version information")
     list(APPEND VERSION_INFO_DEPS git-version-info)
 else()
     # If the version info is static, just generate the CMake script with the
@@ -405,6 +372,7 @@ function (gmx_configure_version_file INFILE OUTFILE)
         VERBATIM)
     if (ARG_TARGET)
         add_custom_target(${ARG_TARGET} DEPENDS ${OUTFILE} VERBATIM)
+        gmx_set_custom_target_output(${ARG_TARGET} ${OUTFILE})
     endif()
     if (ARG_SOURCE_FILE)
         set_source_files_properties(${OUTFILE} PROPERTIES GENERATED true)