From 9195e6bb2b48602890d7ac88c9439f913d36786b Mon Sep 17 00:00:00 2001 From: Joe Jordan Date: Tue, 17 Nov 2020 13:53:46 +0000 Subject: [PATCH] Remove some extraneous compiler flags from nblib Closes #3798 --- api/nblib/CMakeLists.txt | 33 +++++++++++---------------------- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/api/nblib/CMakeLists.txt b/api/nblib/CMakeLists.txt index 250b88da50..a87af61081 100644 --- a/api/nblib/CMakeLists.txt +++ b/api/nblib/CMakeLists.txt @@ -47,31 +47,20 @@ set(IGNORED_CLANG_ALL_WARNINGS "-Wno-covered-switch-default" #GCC gives maybe-uninitialized without default label and checks for illegal enum values. "-Wno-switch-enum" # default statement for enum is OK - # We need to use macros like - # GMX_CATCH_ALL_AND_EXIT_WITH_FATAL_ERROR. Those will look strange - # if they don't have a semicolon after them, and might confuse - # tools like IDEs also. - "-Wno-extra-semi-stmt" - - #Following ones are undecided/TODO - "-Wno-disabled-macro-expansion" - "-Wno-cast-align" - "-Wno-reserved-id-macro" - "-Wno-global-constructors" + # These are all needed, mostly for testing code + "-Wno-conversion" + "-Wno-documentation" + "-Wno-double-promotion" "-Wno-exit-time-destructors" + "-Wno-float-equal" + "-Wno-global-constructors" + "-Wno-padded" + "-Wno-reserved-id-macro" + "-Wno-shadow" "-Wno-unused-macros" "-Wno-weak-vtables" - "-Wno-conditional-uninitialized" - "-Wno-format-nonliteral" - "-Wno-shadow" - "-Wno-cast-qual" - "-Wno-documentation" - "-Wno-used-but-marked-unused" - "-Wno-padded" - "-Wno-float-equal" - "-Wno-old-style-cast" - "-Wno-conversion" - "-Wno-double-promotion") + ) + string(REPLACE " " ";" IGNORED_CLANG_ALL_WARNINGS "${IGNORED_CLANG_ALL_WARNINGS}") set(TESTUTILS_DIR ${PROJECT_SOURCE_DIR}/src/testutils) -- 2.22.0