From 8a22063041268d889781c1d281dc38d7f21cf86f Mon Sep 17 00:00:00 2001 From: Andrey Alekseenko Date: Tue, 8 Jun 2021 15:19:05 +0300 Subject: [PATCH] Fix clang-tidy complaints Introduced in 6cd214d6 (MR !1591) --- src/gromacs/ewald/pme_force_sender_gpu_impl.cu | 3 ++- src/gromacs/ewald/pme_pp_comm_gpu_impl.cu | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gromacs/ewald/pme_force_sender_gpu_impl.cu b/src/gromacs/ewald/pme_force_sender_gpu_impl.cu index b2d32ab884..5356683083 100644 --- a/src/gromacs/ewald/pme_force_sender_gpu_impl.cu +++ b/src/gromacs/ewald/pme_force_sender_gpu_impl.cu @@ -91,7 +91,7 @@ void PmeForceSenderGpu::Impl::setForceSendBuffer(DeviceBuffer d_f) #if GMX_MPI - if (localForcePtr_.size() == 0) + if (localForcePtr_.empty()) { localForcePtr_.resize(ppRanks_.size()); } @@ -132,6 +132,7 @@ void PmeForceSenderGpu::Impl::sendFToPpCudaDirect(int ppRank, int numAtoms) ppCommStream_[ppRank]->stream()); CU_RET_ERR(stat, "cudaMemcpyAsync on Recv from PME CUDA direct data transfer failed"); ppCommEvent_[ppRank]->markEvent(*ppCommStream_[ppRank]); + // NOLINTNEXTLINE(bugprone-sizeof-expression) MPI_Send(&ppCommEvent_[ppRank], sizeof(GpuEventSynchronizer*), MPI_BYTE, ppRank, 0, comm_); #else GMX_UNUSED_VALUE(ppRank); diff --git a/src/gromacs/ewald/pme_pp_comm_gpu_impl.cu b/src/gromacs/ewald/pme_pp_comm_gpu_impl.cu index 66131a808a..8acb6aa671 100644 --- a/src/gromacs/ewald/pme_pp_comm_gpu_impl.cu +++ b/src/gromacs/ewald/pme_pp_comm_gpu_impl.cu @@ -108,6 +108,7 @@ void PmePpCommGpu::Impl::receiveForceFromPmeCudaDirect(float3* recvPtr, bool rec // Recieve event from PME task after PME->PP force data push has // been scheduled and enqueue this to PP stream. GpuEventSynchronizer* eventptr; + // NOLINTNEXTLINE(bugprone-sizeof-expression) MPI_Recv(&eventptr, sizeof(GpuEventSynchronizer*), MPI_BYTE, pmeRank_, 0, comm_, MPI_STATUS_IGNORE); eventptr->enqueueWaitEvent(pmePpCommStream_); -- 2.22.0