From 0b2160c1bbbba3b998d35e0a77e0db3952cb5714 Mon Sep 17 00:00:00 2001 From: "M. Eric Irrgang" Date: Tue, 21 Sep 2021 16:01:22 +0300 Subject: [PATCH] Update MPI dependence for `gmxapi` target. Use the `MPI::MPI_CXX` target instead of deprecated FindMPI output variables. Ref #3672. --- api/gmxapi/CMakeLists.txt | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/api/gmxapi/CMakeLists.txt b/api/gmxapi/CMakeLists.txt index a4caed9e66..1683fc8ae4 100644 --- a/api/gmxapi/CMakeLists.txt +++ b/api/gmxapi/CMakeLists.txt @@ -65,11 +65,7 @@ set_target_properties(gmxapi PROPERTIES if (GMX_LIB_MPI) # GROMACS is built against an MPI library. set(_gmx_mpi_type "library") - # TODO(#3672): Normative solution with #3672. - # Do not target_link_options(gmxapi PRIVATE ${MPI_CXX_LINK_FLAGS}) - # because the root CMakeLists.txt sets CMAKE_SHARED_LINKER_FLAGS. - target_compile_options(gmxapi PUBLIC ${MPI_COMPILE_FLAGS}) - target_link_libraries(gmxapi PUBLIC ${MPI_CXX_LIBRARIES}) + target_link_libraries(gmxapi PRIVATE MPI::MPI_CXX) elseif(GMX_THREAD_MPI) # GROMACS is built with its internal thread-MPI implementation. set(_gmx_mpi_type "tmpi") -- 2.22.0