From: Paul Bauer Date: Wed, 29 Apr 2020 12:47:58 +0000 (+0000) Subject: Print base commit for source linters X-Git-Url: http://biod.pnpi.spb.ru/gitweb/?a=commitdiff_plain;h=9bcec742d50d2509232911f0085ee59ef7bb678d;p=alexxy%2Fgromacs.git Print base commit for source linters Added a printout for the branch used for comparing. Will use to see if branch point selection is working properly and to see if the clang-tidy script picks up the warnings it should. Change-Id: I791d2a11f98cd8e0cf0d06e92a9980cd9d038874 --- diff --git a/admin/gitlab-ci/lint.gitlab-ci.yml b/admin/gitlab-ci/lint.gitlab-ci.yml index e158ddb5f4..5e485d5903 100644 --- a/admin/gitlab-ci/lint.gitlab-ci.yml +++ b/admin/gitlab-ci/lint.gitlab-ci.yml @@ -56,7 +56,13 @@ clang-tidy:test: KUBERNETES_MEMORY_LIMIT: 4Gi script: # TODO (issue #3272) `master` is not appropriate for use on release-xxxx branches, how should we handle that? - - REV=$(git fetch -q https://gitlab.com/gromacs/gromacs.git master && git show -s --pretty=format:"%h" `git merge-base --fork-point FETCH_HEAD HEAD`) + - REV=$(git fetch -q https://gitlab.com/gromacs/gromacs.git master && git show -s --pretty=format:"%h" `git merge-base FETCH_HEAD HEAD`) + - HEAD_REV=$(git show -s --pretty=format:"%h" HEAD) + - if [[ "$REV" == "$HEAD_REV" ]] ; then + REV="HEAD~1" ; + fi + - echo "Revision used for branch point is $REV" + - git show -s $REV - RUN_CLANG_TIDY=run-clang-tidy-$COMPILER_MAJOR_VERSION bash admin/clang-tidy.sh check --parallel=$KUBERNETES_CPU_LIMIT --warnings=clang-tidy.log --rev=$REV -B=$BUILD_DIR - grep -iq "found code issues" clang-tidy.log | tee code-lint.txt || true - if [ -s code-lint.txt ] ; then echo "clang-tidy.sh found issues"; exit 1; fi @@ -83,6 +89,12 @@ clang-format: script: # TODO (issue #3272) `master` is not appropriate for use on release-xxxx branches, how should we handle that? - REV=$(git fetch -q https://gitlab.com/gromacs/gromacs.git master && git show -s --pretty=format:"%h" `git merge-base FETCH_HEAD HEAD`) + - HEAD_REV=$(git show -s --pretty=format:"%h" HEAD) + - if [[ "$REV" == "$HEAD_REV" ]] ; then + REV="HEAD~1" ; + fi + - echo "Revision used for branch point is $REV" + - git show -s $REV - CLANG_FORMAT=clang-format-$COMPILER_MAJOR_VERSION admin/clang-format.sh check --rev=$REV --warnings=clang-format.log - grep -iq "needs formatting" clang-format.log | tee formatting.txt || true - if [ -s formatting.txt ] ; then echo "clang-format.sh found issues"; exit 1; fi @@ -107,6 +119,12 @@ copyright-check: script: # TODO (issue #3272) `master` is not appropriate for use on release-xxxx branches, how should we handle that? - REV=$(git fetch -q https://gitlab.com/gromacs/gromacs.git master && git show -s --pretty=format:"%h" `git merge-base FETCH_HEAD HEAD`) + - HEAD_REV=$(git show -s --pretty=format:"%h" HEAD) + - if [[ "$REV" == "$HEAD_REV" ]] ; then + REV="HEAD~1" ; + fi + - echo "Revision used for branch point is $REV" + - git show -s $REV - admin/copyright.sh check --rev=$REV --warnings=copyright.log - grep -iq "copyright year" copyright.log | tee years.log || true - grep -iq "copyright header" copyright.log | tee headers.log || true