From: Mark Abraham <mark.j.abraham@gmail.com>
Date: Wed, 20 Aug 2014 08:20:21 +0000 (+0200)
Subject: Fix mis-use of fabs in LAPACK
X-Git-Url: http://biod.pnpi.spb.ru/gitweb/?a=commitdiff_plain;h=0ab6c668cdd8903baca46fce059b38ffd95c64ad;p=alexxy%2Fgromacs.git

Fix mis-use of fabs in LAPACK

clang-3.5 warns that fabs is not the right approach.

Change-Id: Ib7125fcad2f4fda99abf7b67f296f24d84cb34be
(cherry picked from commit d9c0e416e180cdd7e0a158d8d9b9e1fe59ef89b7)
---

diff --git a/src/gromacs/linearalgebra/gmx_lapack/dlagts.c b/src/gromacs/linearalgebra/gmx_lapack/dlagts.c
index bc342af697..3f78428588 100644
--- a/src/gromacs/linearalgebra/gmx_lapack/dlagts.c
+++ b/src/gromacs/linearalgebra/gmx_lapack/dlagts.c
@@ -1,3 +1,4 @@
+#include <stdlib.h>
 #include <math.h>
 #include "types/simple.h"
 
@@ -31,7 +32,7 @@ F77_FUNC(dlagts,DLAGTS)(int *job,
     --a;
 
     *info = 0;
-    if (fabs(*job) > 2 || *job == 0) {
+    if (abs(*job) > 2 || *job == 0) {
 	*info = -1;
     } else if (*n < 0) {
 	*info = -2;
@@ -77,7 +78,7 @@ F77_FUNC(dlagts,DLAGTS)(int *job,
 	}
     }
 
-    if (fabs(fabs(*job)-1.0)<GMX_DOUBLE_MIN) {
+    if (1 == abs(*job)) {
 	i__1 = *n;
 	for (k = 2; k <= i__1; ++k) {
 	    if (in[k - 1] == 0) {
diff --git a/src/gromacs/linearalgebra/gmx_lapack/slagts.c b/src/gromacs/linearalgebra/gmx_lapack/slagts.c
index 364234ddc9..ff03ff732d 100644
--- a/src/gromacs/linearalgebra/gmx_lapack/slagts.c
+++ b/src/gromacs/linearalgebra/gmx_lapack/slagts.c
@@ -1,3 +1,4 @@
+#include <stdlib.h>
 #include <math.h>
 #include "types/simple.h"
 
@@ -31,7 +32,7 @@ F77_FUNC(slagts,SLAGTS)(int *job,
     --a;
 
     *info = 0;
-    if (fabs(*job) > 2 || *job == 0) {
+    if (abs(*job) > 2 || *job == 0) {
 	*info = -1;
     } else if (*n < 0) {
 	*info = -2;
@@ -77,7 +78,7 @@ F77_FUNC(slagts,SLAGTS)(int *job,
 	}
     }
 
-    if (fabs(fabs(*job)-1.0)<GMX_FLOAT_MIN) {
+    if (1 == abs(*job)) {
 	i__1 = *n;
 	for (k = 2; k <= i__1; ++k) {
 	    if (in[k - 1] == 0) {