Fix a -Wformat-truncation warning in tng
authorSzilárd Páll <pall.szilard@gmail.com>
Thu, 4 Jul 2019 10:01:19 +0000 (12:01 +0200)
committerSzilárd Páll <pall.szilard@gmail.com>
Thu, 4 Jul 2019 10:01:19 +0000 (12:01 +0200)
Change-Id: Ib0cc008ad50957dededc857adf6bf921f98118b5

src/external/tng_io/src/lib/tng_io.c

index f3236f44df23f17624deeb33fc09d056d0165ab0..9a907de1e300771401a00fb5c0363ce4c9d3bbc5 100644 (file)
@@ -15177,6 +15177,7 @@ tng_function_status DECLSPECDLLEXPORT tng_time_get_str
 {
     struct tm *time_data;
     time_t secs;
+    int retval;
 
     TNG_ASSERT(tng_data, "TNG library: Trajectory container not properly setup.");
     TNG_ASSERT(time, "TNG library: time must not be a NULL pointer");
@@ -15184,12 +15185,13 @@ tng_function_status DECLSPECDLLEXPORT tng_time_get_str
     secs = tng_data->time;
 
     time_data = localtime(&secs); /* Returns a statically allocated variable. */
-    TNG_SNPRINTF(time, TNG_MAX_DATE_STR_LEN,
+    retval = TNG_SNPRINTF(time, TNG_MAX_DATE_STR_LEN,
              "%4d-%02d-%02d %02d:%02d:%02d",
              time_data->tm_year+1900, time_data->tm_mon+1, time_data->tm_mday,
              time_data->tm_hour, time_data->tm_min, time_data->tm_sec);
 
-    return(TNG_SUCCESS);
+    /* handle return value (also) to quiet a -Wformat-truncation warning */
+    return( (retval < 0) ? TNG_SUCCESS : TNG_FAILURE );
 }