Fix issues found with clang-tidy

diff --git a/src/gromacs/timing/wallcycle.cpp b/src/gromacs/timing/wallcycle.cpp
index 4e3e241d9660d6e9f15f582b6c9ce2e362150037..45714a1da2cca611d7ea0709687ed15dae5aff0b 100644 (file)
--- a/src/gromacs/timing/wallcycle.cpp
+++ b/src/gromacs/timing/wallcycle.cpp
@@ -178,7 +178,7 @@ static const char* wcsn[ewcsNR] = {
     "Launch GPU NB X buffer ops.",
     "Launch GPU NB F buffer ops.",
     "Launch GPU Comm. coord.",
-    "Launch GPU Comm. force."
+    "Launch GPU Comm. force.",
     "Test subcounter",
 };
 

diff --git a/src/programs/mdrun/tests/periodicactions.cpp b/src/programs/mdrun/tests/periodicactions.cpp
index 7d145388c400c93dc71be9b54a44fb2faf42ca17..a909f4e6506289c519f25b98e6568c11e34f0361 100644 (file)
--- a/src/programs/mdrun/tests/periodicactions.cpp
+++ b/src/programs/mdrun/tests/periodicactions.cpp
@@ -314,11 +314,11 @@ std::vector<PropagationParameters> propagationParametersWithCoupling()
     std::string nstcomm    = "5";
 
     std::vector<PropagationParameters> parameterSets;
-    for (std::string simulationName : { "argon12" })
+    for (const std::string& simulationName : { "argon12" })
     {
-        for (std::string integrator : { "md", "sd", "md-vv" })
+        for (const std::string& integrator : { "md", "sd", "md-vv" })
         {
-            for (std::string tcoupl : { "no", "v-rescale", "Nose-Hoover" })
+            for (const std::string& tcoupl : { "no", "v-rescale", "Nose-Hoover" })
             {
                 // SD doesn't support temperature-coupling algorithms,
                 if (integrator == "sd" && tcoupl != "no")
@@ -381,11 +381,11 @@ std::vector<PropagationParameters> propagationParametersWithConstraints()
     std::string nstcomm    = "5";
 
     std::vector<PropagationParameters> parameterSets;
-    for (std::string simulationName : { "tip3p5" })
+    for (const std::string& simulationName : { "tip3p5" })
     {
-        for (std::string integrator : { "md", "sd", "md-vv" })
+        for (const std::string& integrator : { "md", "sd", "md-vv" })
         {
-            for (std::string tcoupl : { "no", "v-rescale" })
+            for (const std::string& tcoupl : { "no", "v-rescale" })
             {
                 // SD doesn't support temperature-coupling algorithms,
                 if (integrator == "sd" && tcoupl != "no")