Fix clang 3.2 unintialized variable warnings

All but gmx_sorient were false positives

Change-Id: I3a38b44ad377a929a469a6c6858c81bd77372cb1

diff --git a/src/gmxlib/statutil.c b/src/gmxlib/statutil.c
index fd7ff31cae32ee9c4af1162dcdcef699d0a499db..0175382dabc249268914bc867cf34e74943280a6 100644 (file)
--- a/src/gmxlib/statutil.c
+++ b/src/gmxlib/statutil.c
@@ -341,7 +341,7 @@ static void usage(const char *type,const char *arg)
 
 int iscan(int argc,char *argv[],int *i)
 {
-    int var;
+    int var=0;
     
     if (argc > (*i)+1) {
         if (!sscanf(argv[++(*i)],"%d",&var))
@@ -354,7 +354,7 @@ int iscan(int argc,char *argv[],int *i)
 
 gmx_large_int_t istepscan(int argc,char *argv[],int *i)
 {
-    gmx_large_int_t var;
+    gmx_large_int_t var=0;
     
     if (argc > (*i)+1) {
         if (!sscanf(argv[++(*i)],gmx_large_int_pfmt,&var))
@@ -367,7 +367,7 @@ gmx_large_int_t istepscan(int argc,char *argv[],int *i)
 
 double dscan(int argc,char *argv[],int *i)
 {
-    double var;
+    double var=0;
     
     if (argc > (*i)+1) {
         if (!sscanf(argv[++(*i)],"%lf",&var))

diff --git a/src/kernel/genalg.c b/src/kernel/genalg.c
index 864de3926dd6c69e52432013560e73c3f0699f8d..352b1cab33f3509cfd5e95a763338e754d2f0d21 100644 (file)
--- a/src/kernel/genalg.c
+++ b/src/kernel/genalg.c
@@ -126,7 +126,7 @@ t_genalg *init_ga(FILE *fplog,const char *infile,int D,t_range range[])
 {
   FILE     *fpin_ptr;
   t_genalg *ga;
-  double   ff,cr;
+  double   ff=0,cr=0;
   int      i,j;
   
   /*------Initializations----------------------------*/

diff --git a/src/mdlib/force.c b/src/mdlib/force.c
index 17441e18a64b59ed2e978eeb14d57eb74b14bc8d..3d3699bad0a01b492d94d16484055bf735abe26a 100644 (file)
--- a/src/mdlib/force.c
+++ b/src/mdlib/force.c
@@ -544,6 +544,7 @@ void do_force_lowlevel(FILE       *fplog,   gmx_large_int_t step,
         }
 
         status = 0;
+        Vlr  = 0;
         dvdl = 0;
         switch (fr->eeltype)
         {
@@ -605,12 +606,6 @@ void do_force_lowlevel(FILE       *fplog,   gmx_large_int_t step,
                 }
                 PRINT_SEPDVDL("PME mesh",Vlr,dvdl);
             }
-            else
-            {
-                /* Energies and virial are obtained later from the PME nodes */
-                /* but values have to be zeroed out here */
-                Vlr=0.0;
-            }
             break;
         case eelEWALD:
             Vlr = do_ewald(fplog,FALSE,ir,x,fr->f_novirsum,
@@ -621,7 +616,6 @@ void do_force_lowlevel(FILE       *fplog,   gmx_large_int_t step,
             PRINT_SEPDVDL("Ewald long-range",Vlr,dvdl);
             break;
         default:
-            Vlr = 0;
             gmx_fatal(FARGS,"No such electrostatics method implemented %s",
                       eel_names[fr->eeltype]);
         }
@@ -630,6 +624,7 @@ void do_force_lowlevel(FILE       *fplog,   gmx_large_int_t step,
             gmx_fatal(FARGS,"Error %d in long range electrostatics routine %s",
                       status,EELTYPE(fr->eeltype));
                }
+        /* Note that with separate PME nodes we get the real energies later */
         enerd->dvdl_lin[efptCOUL] += dvdl;
         enerd->term[F_COUL_RECIP] = Vlr + Vcorr;
         if (debug)

diff --git a/src/tools/gmx_h2order.c b/src/tools/gmx_h2order.c
index e495b618620403606c43f000e56707c1bcd961af..73435a7941a88b68f99f74e636c2f4fcc874023e 100644 (file)
--- a/src/tools/gmx_h2order.c
+++ b/src/tools/gmx_h2order.c
@@ -279,11 +279,11 @@ int gmx_h2order(int argc,char *argv[])
   char      *grpname,                      /* groupnames                 */
             *micname;
   int       ngx,                            /* nr. of atomsin sol group   */
-            nmic;                           /* nr. of atoms in micelle    */
+            nmic=0;                           /* nr. of atoms in micelle    */
   t_topology *top;                         /* topology                   */ 
   int       ePBC;
   atom_id    *index,                       /* indices for solvent group  */
-             *micelle;
+             *micelle=NULL;
   gmx_bool       bMicel =  FALSE;               /* think we're a micel        */
   t_filenm  fnm[] = {                      /* files for g_order          */
     { efTRX, "-f", NULL,  ffREAD },                /* trajectory file            */

diff --git a/src/tools/gmx_sorient.c b/src/tools/gmx_sorient.c
index 8df2b4fcb8c0e8aba52fc250759ff33cfee0424a..3a2a00d1c38633549cb49eb2a7a302aa5eca6dbc 100644 (file)
--- a/src/tools/gmx_sorient.c
+++ b/src/tools/gmx_sorient.c
@@ -97,7 +97,7 @@ static void calc_com_pbc(int nrefat,t_topology *top,rvec x[],t_pbc *pbc,
 int gmx_sorient(int argc,char *argv[])
 {
   t_topology top;
-  int      ePBC;
+  int      ePBC=-1;
   char     title[STRLEN];
   t_trxstatus *status;
   int      natoms;