Merge *optioninfo.h to *option.h.
authorTeemu Murtola <teemu.murtola@gmail.com>
Sun, 9 Sep 2012 10:38:29 +0000 (13:38 +0300)
committerGerrit Code Review <gerrit@gerrit.gromacs.org>
Mon, 10 Sep 2012 19:02:30 +0000 (21:02 +0200)
commited6c1ffe8e08df752845714cd3b6e68c56385a6c
tree33b74b08a891c546a55c098d2dfdb95b053f2312
parentaa92e126180314bad5ce2448f227be8f2913fc7f
Merge *optioninfo.h to *option.h.

Merge each *optioninfo.h header to the header that declared the
corresponding public option classes (setManagerForSelectionOptions() was
moved to selectionoptionmanager.*).  After 030c229 (I143592ed), there is
little need to have these in separate headers, as the OptionInfo classes
are now required when creating options.

Not having the implementation split over so many headers makes the code
easier to understand and to maintain, and this outweighs the small
benefits from being able to use the OptionInfo classes without adding a
dependency also on the Option classes (only OptionVisitor would
currently benefit from that).

Adjusted Doxygen documentation for OptionInfo and SelectionOptionInfo
(and some of the files) as part of the reorganization and did some
include cleanup related to the reorganization.  Otherwise, this change
only moves existing code around with no functional changes.

Change-Id: Ic1c62739beca09028887179da26b33516d01624b
33 files changed:
src/gromacs/commandline/cmdlinehelpwriter.cpp
src/gromacs/commandline/tests/cmdlinehelpwriter.cpp
src/gromacs/options.h
src/gromacs/options/CMakeLists.txt
src/gromacs/options/abstractoption.cpp
src/gromacs/options/abstractoption.h
src/gromacs/options/basicoptioninfo.h [deleted file]
src/gromacs/options/basicoptions.cpp
src/gromacs/options/basicoptions.h
src/gromacs/options/basicoptionstorage.h
src/gromacs/options/filenameoption.cpp
src/gromacs/options/filenameoption.h
src/gromacs/options/filenameoptioninfo.h [deleted file]
src/gromacs/options/filenameoptionstorage.h
src/gromacs/options/optioninfo.h [deleted file]
src/gromacs/options/options.h
src/gromacs/options/optionsvisitor.h
src/gromacs/options/tests/abstractoptionstorage.cpp
src/gromacs/options/timeunitmanager.cpp
src/gromacs/selection.h
src/gromacs/selection/CMakeLists.txt
src/gromacs/selection/selectionfileoption.h
src/gromacs/selection/selectionfileoptioninfo.h [deleted file]
src/gromacs/selection/selectionfileoptionstorage.h
src/gromacs/selection/selectionoption.cpp
src/gromacs/selection/selectionoption.h
src/gromacs/selection/selectionoptioninfo.h [deleted file]
src/gromacs/selection/selectionoptionmanager.cpp
src/gromacs/selection/selectionoptionmanager.h
src/gromacs/selection/selectionoptionstorage.h
src/gromacs/selection/tests/selectionoption.cpp
src/gromacs/trajectoryanalysis/cmdlinerunner.cpp
src/gromacs/trajectoryanalysis/modules/angle.cpp