Turn on -Wunused-parameter where applicable
authorMark Abraham <mark.j.abraham@gmail.com>
Tue, 29 Oct 2013 17:53:39 +0000 (18:53 +0100)
committerGerrit Code Review <gerrit@gerrit.gromacs.org>
Sun, 1 Dec 2013 12:34:06 +0000 (13:34 +0100)
commitad69f9f40876d37abbe3c50a26aad7481b4a1963
tree6c363bd6e13c1c6d0736c46e270d79a875c156e2
parent15326145ce4fc939fb31cfe44d966b411f6d0678
Turn on -Wunused-parameter where applicable

There are no longer any function parameters that have function
arguments that are unused (under at least some code paths), unless
they are so noted with gmx_unused attributes. This commit activates
the applicable compiler warnings, so that we can keep it that way!

Some extra changes in gmxomp.c to satisfy Doxygen and remove unused
variable warnings as well (moved the file to C++ compilation).
As a side effect, simplify the #ifdef logic.  The only visible effect of
the reorganization should be that if both affinity environment variables
are set, then the warnings get printed in reverse order.

Also run uncrustify and copyright on changed files.

Change-Id: Ifbaba7543f30c94b44b649718c0c5d7ff1fe5db0
26 files changed:
cmake/gmxCFlags.cmake
src/gromacs/fft/fft_fftpack.c
src/gromacs/fileio/gmx_system_xdr.c
src/gromacs/gmxana/geminate.c
src/gromacs/gmxana/gmx_hbond.c
src/gromacs/gmxlib/gmx_detect_hardware.c
src/gromacs/gmxlib/gmx_thread_affinity.c
src/gromacs/gmxlib/maths.c
src/gromacs/gmxlib/network.c
src/gromacs/legacyheaders/gpu_utils.h
src/gromacs/mdlib/domdec.c
src/gromacs/mdlib/domdec_network.c
src/gromacs/mdlib/forcerec.c
src/gromacs/mdlib/genborn.c
src/gromacs/mdlib/nbnxn_kernels/nbnxn_kernel_simd_utils.h
src/gromacs/mdlib/nbnxn_kernels/nbnxn_kernel_simd_utils_x86_128d.h
src/gromacs/mdlib/nbnxn_kernels/nbnxn_kernel_simd_utils_x86_128s.h
src/gromacs/mdlib/nbnxn_kernels/simd_4xn/nbnxn_kernel_simd_4xn_common.h
src/gromacs/mdlib/nbnxn_search.c
src/gromacs/mdlib/partdec.c
src/gromacs/mdlib/pme.c
src/gromacs/mdlib/pme_pp.c
src/gromacs/timing/wallcycle.c
src/gromacs/utility/gmxomp.cpp [moved from src/gromacs/utility/gmxomp.c with 87% similarity]
src/programs/mdrun/repl_ex.c
src/programs/mdrun/runner.c