Fix issues to update cppcheck support to 1.72
authorMark Abraham <mark.j.abraham@gmail.com>
Tue, 9 Feb 2016 12:51:59 +0000 (13:51 +0100)
committerGerrit Code Review <gerrit@gerrit.gromacs.org>
Wed, 10 Feb 2016 10:53:02 +0000 (11:53 +0100)
commita1214acf0ddd8a78e79b9a77f3a8e22de601e091
treedba741ce70b8d3f1d422c6110567e5327460c6e2
parent4bb0062783748163bdb6c3c64b476a4b22876df0
Fix issues to update cppcheck support to 1.72

Bumped requirement for cppcheck in releng.

Changed the output template to make it easier to find cppcheck's
name for the error when a suppression needs to be added.

Bugs found in gmx_lapack (checked by comparing with Fortran version).

Simplified some checkpoint-reading code, since reading always does the
allocation.

Removed some unused OpenCL debug code.

Removed some suppressions no longer needed.

Change-Id: I882ea877bd489ca253b5a7f06becb7e43bb6a3d0
46 files changed:
admin/builds/cppcheck.py
src/external/thread_mpi/include/thread_mpi/system_error.h
src/gromacs/commandline/cmdlineparser.h
src/gromacs/commandline/cmdlineprogramcontext.cpp
src/gromacs/correlationfunctions/expfit.cpp
src/gromacs/domdec/domdec.cpp
src/gromacs/ewald/pme-pp.cpp
src/gromacs/fft/fft5d.cpp
src/gromacs/fileio/checkpoint.cpp
src/gromacs/fileio/espio.cpp
src/gromacs/fileio/libxdrf.cpp
src/gromacs/fileio/pdbio.cpp
src/gromacs/fileio/tngio_for_tools.cpp
src/gromacs/gmxana/gmx_chi.cpp
src/gromacs/gmxana/gmx_densmap.cpp
src/gromacs/gmxana/gmx_disre.cpp
src/gromacs/gmxana/gmx_eneconv.cpp
src/gromacs/gmxana/gmx_energy.cpp
src/gromacs/gmxana/gmx_hbond.cpp
src/gromacs/gmxana/gmx_nmeig.cpp
src/gromacs/gmxana/gmx_pme_error.cpp
src/gromacs/gmxana/gmx_sham.cpp
src/gromacs/gmxana/gmx_xpm2ps.cpp
src/gromacs/gmxlib/network.cpp
src/gromacs/gmxpreprocess/topio.cpp
src/gromacs/gmxpreprocess/toppush.cpp
src/gromacs/linearalgebra/gmx_arpack.cpp
src/gromacs/linearalgebra/gmx_lapack/dlasv2.cpp
src/gromacs/linearalgebra/gmx_lapack/slasv2.cpp
src/gromacs/mdlib/mdoutf.cpp
src/gromacs/mdlib/minimize.cpp
src/gromacs/mdlib/nbnxn_ocl/nbnxn_ocl.cpp
src/gromacs/mdlib/nbnxn_search.cpp
src/gromacs/options/optionstoragetemplate.h
src/gromacs/selection/parsetree.cpp
src/gromacs/selection/scanner_internal.cpp
src/gromacs/selection/sm_insolidangle.cpp
src/gromacs/topology/atoms.cpp
src/gromacs/topology/index.cpp
src/gromacs/topology/mtop_util.cpp
src/gromacs/topology/residuetypes.cpp
src/gromacs/trajectoryanalysis/modules/angle.cpp
src/gromacs/trajectoryanalysis/modules/freevolume.cpp
src/gromacs/trajectoryanalysis/runnercommon.cpp
src/testutils/tests/interactivetest.cpp
tests/CppCheck.cmake