Fix some issues found by cppcheck-1.58.
authorTeemu Murtola <teemu.murtola@gmail.com>
Thu, 30 May 2013 04:05:26 +0000 (07:05 +0300)
committerTeemu Murtola <teemu.murtola@gmail.com>
Thu, 27 Jun 2013 18:03:23 +0000 (21:03 +0300)
commit1f1a788d9cad9ec07d2ec8b5cf5f813bd8370292
tree7565f7ff27127daa1498683a55a69939e3b0ecf4
parentbebc698f72060d89123ed4bdf5bd40dbdd830c0f
Fix some issues found by cppcheck-1.58.

Some are real (although unlikely) bugs, others are just removal of
unnecessary code or stylistic changes. Fixes about 1/3 of the issues
this version of cppcheck finds; the remaining aren't as easily fixed and
most look like false positives.

Change-Id: Ic7ba3cc26be9906e037ecec9f8e63739ac3786be
12 files changed:
src/gromacs/analysisdata/modules/displacement.cpp
src/gromacs/commandline/cmdlinemodulemanager.cpp
src/gromacs/gmxana/gmx_make_ndx.c
src/gromacs/gmxana/gmx_saltbr.c
src/gromacs/gmxlib/gmx_cpuid.c
src/gromacs/gmxlib/nonbonded/nb_free_energy.c
src/gromacs/gmxlib/tpxio.c
src/gromacs/mdlib/qm_orca.c
src/gromacs/mdlib/tables.c
src/gromacs/options/basicoptions.cpp
src/gromacs/selection/sm_keywords.cpp
src/programs/gmx/tpbcmp.c