Update cppcheck support to 1.76.1
authorMark Abraham <mark.j.abraham@gmail.com>
Tue, 18 Oct 2016 15:32:06 +0000 (17:32 +0200)
committerMark Abraham <mark.j.abraham@gmail.com>
Fri, 21 Oct 2016 07:59:24 +0000 (09:59 +0200)
commit7dffe13ebf80f29197e83d554493e8036c819a61
treefce543ac16f1430cf1821add49b7a49377cf154e
parent37595636dc9c1a65ca9f3a68da78373bc60a49d3
Update cppcheck support to 1.76.1

Suppressed some classes of warnings where cppcheck was systematically
failing (for at least some source files). Added assert statements
to cover others.

Propagated some const correctness.

Replaced some block_* macros with templated functions in a header
that we re-use in a few places.

The gmx_arpack and lapack issues were inherited from the original
FORTRAN.

The simd/support.cpp issue is a bug that is fixed in release-2016.

Removed some unnecessary stderr output.

Noted TODOs for further cleanup.

Change-Id: Ia93690e3dbd529ef27e5b7f8331d12a2f7d34766
45 files changed:
admin/builds/cppcheck.py
src/gromacs/commandline/pargs.cpp
src/gromacs/domdec/domdec_topology.cpp
src/gromacs/essentialdynamics/edsam.cpp
src/gromacs/fft/fft_fftpack.cpp
src/gromacs/fft/fft_mkl.cpp
src/gromacs/fileio/enxio.cpp
src/gromacs/fileio/oenv.cpp
src/gromacs/fileio/tpxio.cpp
src/gromacs/fileio/xvgr.cpp
src/gromacs/gmxana/binsearch.cpp
src/gromacs/gmxana/gmx_anaeig.cpp
src/gromacs/gmxana/gmx_cluster.cpp
src/gromacs/gmxana/gmx_mindist.cpp
src/gromacs/gmxana/gmx_pme_error.cpp
src/gromacs/gmxana/gmx_rmsf.cpp
src/gromacs/gmxana/gmx_wham.cpp
src/gromacs/gmxana/nrama.cpp
src/gromacs/gmxana/nsfactor.cpp
src/gromacs/gmxpreprocess/convparm.cpp
src/gromacs/gmxpreprocess/gen_ad.cpp
src/gromacs/gmxpreprocess/grompp-impl.h
src/gromacs/gmxpreprocess/h_db.cpp
src/gromacs/gmxpreprocess/pdb2top.cpp
src/gromacs/gmxpreprocess/resall.cpp
src/gromacs/imd/imd.cpp
src/gromacs/linearalgebra/gmx_arpack.cpp
src/gromacs/linearalgebra/gmx_lapack/dstebz.cpp
src/gromacs/linearalgebra/gmx_lapack/sstebz.cpp
src/gromacs/mdlib/broadcaststructs.cpp
src/gromacs/mdlib/broadcaststructs.h [new file with mode: 0644]
src/gromacs/mdlib/forcerec.cpp
src/gromacs/mdlib/gmx_omp_nthreads.cpp
src/gromacs/mdlib/mdebin_bar.cpp
src/gromacs/mdlib/nbnxn_kernels/nbnxn_kernel_ref_inner.h
src/gromacs/options/valuestore.h
src/gromacs/selection/centerofmass.cpp
src/gromacs/selection/selelem.cpp
src/gromacs/simd/support.cpp
src/gromacs/topology/index.cpp
src/gromacs/topology/symtab.cpp
src/programs/view/dialogs.cpp
src/programs/view/manager.cpp
src/programs/view/nmol.cpp
tests/CppCheck.cmake