* This file is part of the GROMACS molecular simulation package.
*
* Copyright (c) 2012,2014,2015,2016,2017 by the GROMACS development team.
- * Copyright (c) 2018,2019,2020, by the GROMACS development team, led by
+ * Copyright (c) 2018,2019,2020,2021, by the GROMACS development team, led by
* Mark Abraham, David van der Spoel, Berk Hess, and Erik Lindahl,
* and including many others, as listed in the AUTHORS file in the
* top-level source directory and at http://www.gromacs.org.
#include <array>
#include <string>
+#include <type_traits>
+#include "gromacs/gpu_utils/device_stream.h"
#include "gromacs/gpu_utils/gputraits.cuh"
#include "gromacs/math/vec.h"
#include "gromacs/math/vectypes.h"
namespace
{
+/*! \brief Add the API information on the specific error to the error message.
+ *
+ * \param[in] deviceError The error to assert cudaSuccess on.
+ *
+ * \returns A description of the API error. Returns '(CUDA error #0 (cudaSuccess): no error)' in case deviceError is cudaSuccess.
+ */
+inline std::string getDeviceErrorString(const cudaError_t deviceError)
+{
+ return formatString("CUDA error #%d (%s): %s.",
+ deviceError,
+ cudaGetErrorName(deviceError),
+ cudaGetErrorString(deviceError));
+}
+
+/*! \brief Check if API returned an error and throw an exception with information on it.
+ *
+ * \param[in] deviceError The error to assert cudaSuccess on.
+ * \param[in] errorMessage Undecorated error message.
+ *
+ * \throws InternalError if deviceError is not a success.
+ */
+inline void checkDeviceError(const cudaError_t deviceError, const std::string& errorMessage)
+{
+ if (deviceError != cudaSuccess)
+ {
+ GMX_THROW(gmx::InternalError(errorMessage + " " + getDeviceErrorString(deviceError)));
+ }
+}
+
/*! \brief Helper function to ensure no pending error silently
* disrupts error handling.
*
* Asserts in a debug build if an unhandled error is present. Issues a
* warning at run time otherwise.
*
- * \todo This is similar to CU_CHECK_PREV_ERR, which should be
- * consolidated.
+ * \param[in] errorMessage Undecorated error message.
*/
-static inline void ensureNoPendingCudaError(const char* errorMessage)
+inline void ensureNoPendingDeviceError(const std::string& errorMessage)
{
// Ensure there is no pending error that would otherwise affect
// the behaviour of future error handling.
- cudaError_t stat = cudaGetLastError();
- if (stat == cudaSuccess)
+ cudaError_t deviceError = cudaGetLastError();
+ if (deviceError == cudaSuccess)
{
return;
}
// If we would find an error in a release build, we do not know
// what is appropriate to do about it, so assert only for debug
// builds.
- auto fullMessage = formatString(
- "%s An unhandled error from a previous CUDA operation was detected. %s: %s",
- errorMessage, cudaGetErrorName(stat), cudaGetErrorString(stat));
- GMX_ASSERT(stat == cudaSuccess, fullMessage.c_str());
+ const std::string fullErrorMessage =
+ errorMessage + " An unhandled error from a previous CUDA operation was detected. "
+ + gmx::getDeviceErrorString(deviceError);
+ GMX_ASSERT(deviceError == cudaSuccess, fullErrorMessage.c_str());
// TODO When we evolve a better logging framework, use that
// for release-build error reporting.
- gmx_warning("%s", fullMessage.c_str());
+ gmx_warning("%s", fullErrorMessage.c_str());
}
} // namespace
#ifdef CHECK_CUDA_ERRORS
/*! Check for CUDA error on the return status of a CUDA RT API call. */
-# define CU_RET_ERR(status, msg) \
- do \
- { \
- if (status != cudaSuccess) \
- { \
- gmx_fatal(FARGS, "%s: %s\n", msg, cudaGetErrorString(status)); \
- } \
- } while (0)
-
-/*! Check for any previously occurred uncaught CUDA error. */
-# define CU_CHECK_PREV_ERR() \
- do \
- { \
- cudaError_t _CU_CHECK_PREV_ERR_status = cudaGetLastError(); \
- if (_CU_CHECK_PREV_ERR_status != cudaSuccess) \
- { \
- gmx_warning( \
- "Just caught a previously occurred CUDA error (%s), will try to " \
- "continue.", \
- cudaGetErrorString(_CU_CHECK_PREV_ERR_status)); \
- } \
+# define CU_RET_ERR(deviceError, msg) \
+ do \
+ { \
+ if ((deviceError) != cudaSuccess) \
+ { \
+ gmx_fatal(FARGS, "%s\n", ((msg) + gmx::getDeviceErrorString(deviceError)).c_str()); \
+ } \
} while (0)
#else /* CHECK_CUDA_ERRORS */
do \
{ \
} while (0)
-# define CU_CHECK_PREV_ERR() \
- do \
- { \
- } while (0)
#endif /* CHECK_CUDA_ERRORS */
return false;
}
- GMX_ASSERT(stat != cudaErrorInvalidResourceHandle, "Stream idnetifier not valid");
+ GMX_ASSERT(stat != cudaErrorInvalidResourceHandle,
+ ("Stream identifier not valid. " + gmx::getDeviceErrorString(stat)).c_str());
// cudaSuccess and cudaErrorNotReady are the expected return values
- CU_RET_ERR(stat, "Unexpected cudaStreamQuery failure");
+ CU_RET_ERR(stat, "Unexpected cudaStreamQuery failure. ");
GMX_ASSERT(stat == cudaSuccess,
- "Values other than cudaSuccess should have been explicitly handled");
+ ("Values other than cudaSuccess should have been explicitly handled. "
+ + gmx::getDeviceErrorString(stat))
+ .c_str());
return true;
}
const CurrentArg* argPtr,
const RemainingArgs*... otherArgsPtrs)
{
- (*kernelArgsPtr)[argIndex] = (void*)argPtr;
+ (*kernelArgsPtr)[argIndex] = const_cast<void*>(static_cast<const void*>(argPtr));
prepareGpuKernelArgument(kernel, kernelArgsPtr, argIndex + 1, otherArgsPtrs...);
}
* \param[in] deviceStream GPU stream to launch kernel in
* \param[in] kernelName Human readable kernel description, for error handling only
* \param[in] kernelArgs Array of the pointers to the kernel arguments, prepared by
- * prepareGpuKernelArguments() \throws gmx::InternalError on kernel launch failure
+ * prepareGpuKernelArguments()
+ * \throws gmx::InternalError on kernel launch failure
*/
template<typename... Args>
void launchGpuKernel(void (*kernel)(Args...),
{
dim3 blockSize(config.blockSize[0], config.blockSize[1], config.blockSize[2]);
dim3 gridSize(config.gridSize[0], config.gridSize[1], config.gridSize[2]);
- cudaLaunchKernel((void*)kernel, gridSize, blockSize, const_cast<void**>(kernelArgs.data()),
- config.sharedMemorySize, deviceStream.stream());
-
- cudaError_t status = cudaGetLastError();
- if (cudaSuccess != status)
- {
- const std::string errorMessage =
- "GPU kernel (" + std::string(kernelName)
- + ") failed to launch: " + std::string(cudaGetErrorString(status));
- GMX_THROW(gmx::InternalError(errorMessage));
- }
+ cudaLaunchKernel(reinterpret_cast<void*>(kernel),
+ gridSize,
+ blockSize,
+ const_cast<void**>(kernelArgs.data()),
+ config.sharedMemorySize,
+ deviceStream.stream());
+
+ gmx::ensureNoPendingDeviceError("GPU kernel (" + std::string(kernelName)
+ + ") failed to launch.");
}
#endif
biod.pnpi.spb.ru / alexxy / gromacs.git / blobdiff