readability-implicit-bool-conversion 1/2

[alexxy/gromacs.git] / src / gromacs / fileio / groio.cpp

diff --git a/src/gromacs/fileio/groio.cpp b/src/gromacs/fileio/groio.cpp
index 8833b4b3d708dff2ae7f163083952887aa494e93..8038330369f3f0f434f1ad80583f722b48d0e931 100644 (file)
--- a/src/gromacs/fileio/groio.cpp
+++ b/src/gromacs/fileio/groio.cpp
@@ -325,13 +325,13 @@ void gmx_gro_read_conf(const char *infile,
 static gmx_bool gmx_one_before_eof(FILE *fp)
 {
     char     data[4];
-    gmx_bool beof;
+    gmx_bool beof = fread(data, 1, 1, fp) != 1;
 
-    if ((beof = fread(data, 1, 1, fp)) == 1)
+    if (!beof)
     {
         gmx_fseek(fp, -1, SEEK_CUR);
     }
-    return !beof;
+    return beof;
 }
 
 gmx_bool gro_next_x_or_v(FILE *status, t_trxframe *fr)