Require pybind 2.6 from environment for gmxapi Python package extension module.

[alexxy/gromacs.git] / python_packaging / docker / ci.dockerfile

diff --git a/python_packaging/docker/ci.dockerfile b/python_packaging/docker/ci.dockerfile
index b5d6a1252d532b336b71869cb772129f480dff30..f503a5b7131c99fc73ad85c0f73df4bfb88e8a70 100644 (file)
--- a/python_packaging/docker/ci.dockerfile
+++ b/python_packaging/docker/ci.dockerfile
@@ -12,23 +12,16 @@
 # Build from the GROMACS image at the current fork point. Tag with the feature
 # name or the current revision.
 #
-#    FORKPOINT=$(git show -s --pretty=format:"%h" `git merge-base gerrit_master HEAD`)
+#    FORKPOINT=$(git show -s --pretty=format:"%h" `git merge-base master HEAD`)
 #    REF=`git show -s --pretty=format:"%h"`
 #    # or
 #    REF="fr1"
 #    docker build -t gmxapi/ci-mpich:${REF} --build-arg REF=${FORKPOINT} -f ci.dockerfile ..
 #
 
-#
-# Use gromacs installation from gmxapi/gromacs image
-#
-
 ARG REF=latest
-FROM gmxapi/gromacs-mpich:$REF as gromacs
-# This intermediate is necessary because the COPY command does not support syntax like the following:
-#COPY --from=gmxapi/gromacs:$REF /usr/local/gromacs /usr/local/gromacs
 
-FROM gmxapi/gromacs-dependencies-mpich
+FROM gmxapi/gromacs-dependencies-mpich as python-base
 
 RUN apt-get update && \
     apt-get -yq --no-install-suggests --no-install-recommends install \
@@ -40,48 +33,62 @@ RUN apt-get update && \
 # TODO: Use non-system Python installations for explicit version coverage.
 # Consider pyenv for generic management of Python environment.
 
-ENV CMAKE_ROOT /usr/local/cmake
-ENV PATH $CMAKE_ROOT/bin:$PATH
-
 RUN groupadd -r testing && useradd -m -s /bin/bash -g testing testing
 
 USER testing
 
-# TODO: Clean up pip cache.
-RUN python3 -m venv $HOME/testing
-RUN . $HOME/testing/bin/activate && \
-    pip install --no-cache-dir --upgrade pip setuptools
+ENV VENV /home/testing/venv
+RUN python3 -m venv $VENV
+RUN . $VENV/bin/activate && \
+    pip install --no-cache-dir --upgrade pip setuptools wheel
 
 ADD --chown=testing:testing requirements-*.txt /home/testing/gmxapi/
 
-RUN . $HOME/testing/bin/activate && \
-    pip install --no-cache-dir -r /home/testing/gmxapi/requirements-test.txt
+#
+# Use gromacs installation from gmxapi/gromacs image
+#
+
+FROM gmxapi/gromacs-mpich:$REF as gromacs
+# This intermediate is necessary because the COPY command does not support syntax like the following:
+#COPY --from=gmxapi/gromacs:$REF /usr/local/gromacs /usr/local/gromacs
+
+FROM python-base
 
-COPY --from=gromacs $CMAKE_ROOT $CMAKE_ROOT
 COPY --from=gromacs /usr/local/gromacs /usr/local/gromacs
 
+RUN $VENV/bin/python -m pip install --upgrade pip setuptools wheel
+RUN $VENV/bin/python -m pip install --no-cache-dir --no-build-isolation -r /home/testing/gmxapi/requirements-test.txt
+
 ADD --chown=testing:testing src /home/testing/gmxapi/src
 ADD --chown=testing:testing src/gmxapi /home/testing/gmxapi/src/gmxapi
 
-RUN . $HOME/testing/bin/activate && \
-    . /usr/local/gromacs/bin/GMXRC && \
+# We use "--no-cache-dir" to reduce Docker image size.
+RUN . $VENV/bin/activate && \
     (cd $HOME/gmxapi/src && \
-     pip install --no-cache-dir . \
+     rm -rf build dist && \
+     GMXTOOLCHAINDIR=/usr/local/gromacs/share/cmake/gromacs \
+      pip install --no-cache-dir --verbose . \
     )
 
 ADD --chown=testing:testing src/test /home/testing/gmxapi/test
-ADD --chown=testing:testing scripts /home/testing/scripts
-ADD --chown=testing:testing test /home/testing/test
+ADD scripts /docker_entry_points
 
 ADD --chown=testing:testing sample_restraint /home/testing/sample_restraint
 
-RUN . $HOME/testing/bin/activate && \
+# TODO: (#3027) Get googletest sources locally.
+RUN . $VENV/bin/activate && \
     . /usr/local/gromacs/bin/GMXRC && \
     (cd $HOME/sample_restraint && \
      mkdir build && \
      cd build && \
-     cmake .. && \
-     make -j4 install \
+     cmake .. \
+             -DPYTHON_EXECUTABLE=$VENV/bin/python \
+             -DDOWNLOAD_GOOGLETEST=ON \
+             -DGMXAPI_EXTENSION_DOWNLOAD_PYBIND=ON && \
+     make -j4 && \
+     make tests && \
+     make test && \
+     make install \
     )
 
 # TODO: this can be in the root user section above once it is stable